[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-123086370 Note: I merged it in master (1.5.0), as well as branch-1.4 (1.4.2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122989489 I merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122972146 Actually I'm having some trouble with ASF git. I will merge when that works. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122971227 Thanks! Going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122961596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122961503 [Test build #37847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37847/console) for PR 7499 at commit [`dd75aa6`](https://github.

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122955541 [Test build #37847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37847/consoleFull) for PR 7499 at commit [`dd75aa6`](https://gith

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122954184 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122954139 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122952444 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-20 Thread sixers
Github user sixers commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122788836 @JoshRosen I see, thanks for suggestion, I added this test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122726109 @sixers, my suggestion was to add an end-to-end test, like `sqlContext.sql("select null").collect()`, to PySpark SQL's `SQLTests` unittest suite: https://github.com/a

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-19 Thread sixers
Github user sixers commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122690858 @JoshRosen @davies @rxin This is my first contribution to Spark, would you give me some directions where to put this test? In general what is

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122612551 @JoshRosen I see, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122597933 @rxin, @davies, the JIRA ticket contains an example a query that fails due to this issue: https://issues.apache.org/jira/browse/SPARK-9101 @sixers, it might be

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122590188 It can happen if there is a null literal -- I'm not sure what happens in Python though. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122590035 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122590019 [Test build #37728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37728/console) for PR 7499 at commit [`97e3f2f`](https://github.

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122589717 I'm just wondering that is there a real use case that need NullType? Currently, it's only used during type inferring. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122588867 [Test build #37728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37728/consoleFull) for PR 7499 at commit [`97e3f2f`](https://gith

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122588724 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122588731 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122588311 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122588329 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122581353 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7499#issuecomment-122581310 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-9101] [PySpark] Add missing NullType

2015-07-18 Thread sixers
GitHub user sixers opened a pull request: https://github.com/apache/spark/pull/7499 [SPARK-9101] [PySpark] Add missing NullType JIRA: https://issues.apache.org/jira/browse/SPARK-9101 You can merge this pull request into a Git repository by running: $ git pull https://github.com