[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-29 Thread badriub
Github user badriub commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35773080 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -19,23 +19,24 @@ package org.apache.spark.ml.classification

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-29 Thread badriub
Github user badriub commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35773166 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -127,10 +128,16 @@ final class OneVsRestModel private[ml] (

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-28 Thread badriub
Github user badriub commented on the pull request: https://github.com/apache/spark/pull/7652#issuecomment-125600947 I have replied on the JIRA, please take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7652#issuecomment-124731476 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35468419 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -114,6 +114,51 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7652#issuecomment-124731748 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35468461 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -19,6 +19,8 @@ package org.apache.spark.ml.classification

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35468265 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala --- @@ -17,7 +17,10 @@ package org.apache.spark.mllib.regression

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35468251 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala --- @@ -37,6 +40,13 @@ class LassoModel ( extends

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7652#discussion_r35468291 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala --- @@ -73,6 +73,13 @@ class SVMModel ( this } +

[GitHub] spark pull request: [SPARK-9312] [MLLIB] Added predictive probabil...

2015-07-24 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7652#issuecomment-124780680 @badriub I just added some thoughts on the JIRA. Could you please take a look and respond there? Thanks! --- If your project is set up for it, you can reply to