[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-26 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134852794 Thanks @felixcheung -- Merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134835162 [Test build #41599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41599/consoleFull) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134840751 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134840021 [Test build #41599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41599/console) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134840758 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134834275 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134834283 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-25 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134503719 Thanks @felixcheung -- this LGTM to me as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134298946 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134306562 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134306385 [Test build #41458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41458/console) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134297751 cc @sun-rui @falaki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134300092 [Test build #41458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41458/consoleFull) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134306560 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134297737 Jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134298972 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/8394 [SPARK-9316] [SPARKR] Add support for filtering using `[` (synonym for filter / select) Add support for ``` df[df$name == Smith, c(1,2)] df[df$age %in% c(19, 30), 1:2] ```

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134078960 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37832964 --- Diff: R/pkg/R/DataFrame.R --- @@ -945,6 +947,19 @@ setMethod([, signature(x = DataFrame, i = missing), select(x, j) })

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134474759 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134471688 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37827367 --- Diff: R/pkg/R/DataFrame.R --- @@ -945,6 +947,19 @@ setMethod([, signature(x = DataFrame, i = missing), select(x, j) })

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37827391 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -587,6 +587,29 @@ test_that(select with column, { expect_equal(collect(select(df3, x))[[1, 1]], x)

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37832421 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -587,6 +587,29 @@ test_that(select with column, { expect_equal(collect(select(df3, x))[[1, 1]],

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37832419 --- Diff: R/pkg/R/DataFrame.R --- @@ -945,6 +947,19 @@ setMethod([, signature(x = DataFrame, i = missing), select(x, j)

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134471928 [Test build #41517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41517/consoleFull) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37832844 --- Diff: R/pkg/R/DataFrame.R --- @@ -945,6 +947,19 @@ setMethod([, signature(x = DataFrame, i = missing), select(x, j) })

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134474719 [Test build #41517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41517/console) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134474762 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134455987 LGTM. some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134471696 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not