[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-10-15 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/7653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-10-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-148506837 I'm going to go ahead and close this PR for now because I don't have time to finish getting it merged. AFAIK the user that I created this patch for has solved their

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-09-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7653#discussion_r38493733 --- Diff: core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferTimeoutSuite.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-09-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7653#discussion_r38493657 --- Diff: network/common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -40,6 +40,11 @@ public int connectionTimeoutMs() {

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-09-01 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-136916165 Currently there's no persistent connection between a client and the shuffle server, right? That seems to be the case from reading `NettyBlockTransferService.scala`. If

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-08-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-136522632 @vanzin wanna review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126445786 This patch merges and builds, but not on Jenkins due to some environment issues there. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126432624 [Test build #39082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39082/consoleFull) for PR 7653 at commit

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126432639 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126427597 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126427770 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126427793 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-126429596 [Test build #39082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39082/consoleFull) for PR 7653 at commit

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-124750253 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-124751105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-124750977 [Test build #38405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38405/consoleFull) for PR 7653 at commit

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-124751096 [Test build #38405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38405/consoleFull) for PR 7653 at commit

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7653#issuecomment-124750231 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/7653 [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeouts to Netty IO layer Spark's Netty-based network layer does not implement read timeouts which may lead to stalls during shuffle: if a remote shuffle

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7653#discussion_r35473025 --- Diff: core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferTimeoutSuite.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

2015-07-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7653#discussion_r35473018 --- Diff: core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferTimeoutSuite.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the