[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/7673 [SPARK-9355][SQL] Remove InternalRow.get generic getter call in columnar cache code You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124964723 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124964713 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124965376 [Test build #38466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38466/consoleFull) for PR 7673 at commit [`eeae712`](https://gith

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124966168 [Test build #38466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38466/console) for PR 7673 at commit [`eeae712`](https://github.

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124966170 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124969504 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124969486 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124969865 [Test build #38471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38471/consoleFull) for PR 7673 at commit [`88b1170`](https://gith

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124977034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124976871 [Test build #38471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38471/console) for PR 7673 at commit [`88b1170`](https://github.

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-124984577 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-125053515 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-125058068 @liancheng can you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-125336106 OK I took a look and the changes looked alright. I'm going to merge this. @liancheng it would be great if you can take a look at this post-hoc too. --- If your pr

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/7673#discussion_r35664015 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala --- @@ -434,18 +441,18 @@ private[sql] object BINARY extends ByteArrayColu

[GitHub] spark pull request: [SPARK-9355][SQL] Remove InternalRow.get gener...

2015-07-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/7673#issuecomment-125663231 Sorry, missed this PR yesterday. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project