[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35616321 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -236,6 +236,41 @@ public Object get(int ordinal) {

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35616151 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -236,6 +236,41 @@ public Object get(int ordinal) {

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35615980 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -236,6 +236,41 @@ public Object get(int ordinal) {

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125095910 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125095087 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125095043 [Test build #38501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38501/console) for PR 7682 at commit [`3063788`](https://github.

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125091810 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125090141 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125090123 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125089089 Hmm, that `partcols1` test seems like it might be flaky. I think it uses the script transform. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35506212 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -436,4 +471,19 @@ public String toString() { public

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35506188 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -436,4 +471,19 @@ public String toString() { pu

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125086565 [Test build #38498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38498/console) for PR 7682 at commit [`9989064`](https://github.

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125086582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125084587 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125083040 [Test build #38501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38501/consoleFull) for PR 7682 at commit [`3063788`](https://gith

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125082055 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125082027 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125080828 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125080820 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125076380 [Test build #38498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38498/consoleFull) for PR 7682 at commit [`9989064`](https://gith

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125075376 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125075413 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125074354 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125074352 [Test build #38497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38497/console) for PR 7682 at commit [`11f80a3`](https://github.

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125074045 [Test build #38497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38497/consoleFull) for PR 7682 at commit [`11f80a3`](https://gith

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125073861 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7682#issuecomment-125073814 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-26 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/7682 [SPARK-9368][SQL] Support get(ordinal, dataType) generic getter in UnsafeRow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark unsaferow