[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-29 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/7744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/7744#discussion_r35745491 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -92,7 +92,8 @@ public static int calculateBitSetWidthInBy

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-29 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125905838 We must change these getter/setter interfaces? ISTM that `setDecimal(i: ordinal, value: Decimal)` serializes the value with the precision/scale that the input decimal

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125872753 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125872691 [Test build #38812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38812/console) for PR 7744 at commit [`f2810f6`](https://github.

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125854833 [Test build #38812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38812/consoleFull) for PR 7744 at commit [`f2810f6`](https://gith

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125854843 @viirya Thanks for working on this. It seems that your patch only works for precision <= 18, we should support the full range (0 < precision <= 38). Because we al

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125854302 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7744#issuecomment-125854284 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9370][SQL] Add DecimalType support in U...

2015-07-28 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/7744 [SPARK-9370][SQL] Add DecimalType support in UnsafeRow JIRA: https://issues.apache.org/jira/browse/SPARK-9370 Add `DecimalType` support in `UnsafeRow`. You can merge this pull request into