Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8866
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168816011
LGTM
Thanks for the PR!
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48772445
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -129,6 +136,22 @@ final class DecisionTreeRegressionModel
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168125010
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168125011
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168124891
**[Test build #48537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48537/consoleFull)**
for PR 8866 at commit
[`ad6b24c`](https://git
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48646093
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -129,6 +136,22 @@ final class DecisionTreeRegressionModel
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168119453
**[Test build #48537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48537/consoleFull)**
for PR 8866 at commit
[`ad6b24c`](https://gith
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-168040193
Thanks for the updates!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48617867
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val s
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48617831
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -129,6 +136,22 @@ final class DecisionTreeRegressionModel
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167969755
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167969753
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167969669
**[Test build #48469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48469/consoleFull)**
for PR 8866 at commit
[`ec0f880`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167964510
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167964508
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167964432
**[Test build #48467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48467/consoleFull)**
for PR 8866 at commit
[`ec0f880`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167959856
**[Test build #48469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48469/consoleFull)**
for PR 8866 at commit
[`ec0f880`](https://gith
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167957884
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167957852
@jkbradley Thanks for your comments, I have updated the PR and resolve
conflicts.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167957833
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167957832
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48591863
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48591821
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167957619
**[Test build #48467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48467/consoleFull)**
for PR 8866 at commit
[`ec0f880`](https://gith
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48591785
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -113,6 +114,22 @@ final class DecisionTreeRegressionModel
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-167909036
@yanboliang Apologies for the delay! I'm resuming regular reviews now and
will prioritize this.
Could you please resolve the merge conflicts?
Also, c
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48581488
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val s
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48581486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -113,6 +114,22 @@ final class DecisionTreeRegressionModel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48581487
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val s
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48581489
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val s
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-163697528
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-163697530
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-163697282
[Test build #47503 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47503/console)
for PR 8866 at commit
[`019b13e`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-163647400
[Test build #47503 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47503/consoleFull)
for PR 8866 at commit
[`019b13e`](https://gith
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-150176392
@jkbradley I restricted ```varianceCol``` to only DecisionTreeRegressor and
remove default value, so it's validated only when users specified.
---
If your project is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-150013588
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-150013590
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-150013422
**[Test build #44076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44076/consoleFull)**
for PR 8866 at commit
[`019b13e`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149981212
**[Test build #44076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44076/consoleFull)**
for PR 8866 at commit
[`019b13e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149979224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149979221
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149979048
**[Test build #44074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44074/consoleFull)**
for PR 8866 at commit
[`21048d9`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149978900
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149978926
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149967973
**[Test build #44074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44074/consoleFull)**
for PR 8866 at commit
[`21048d9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149966861
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-149966892
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r42274055
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148793612
Thanks for your updates! Let me know if the proposal sounds workable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r42273886
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -44,6 +44,8 @@ private[shared] object SharedParamsCodeGen
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r42273654
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -214,7 +216,7 @@ private[ml] object TreeClassifierParams {
/**
* P
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r42273648
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148040769
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148040767
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148040618
[Test build #43718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43718/console)
for PR 8866 at commit
[`17aaa09`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148029729
[Test build #43718 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43718/consoleFull)
for PR 8866 at commit
[`17aaa09`](https://gith
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r41984815
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -214,7 +216,7 @@ private[ml] object TreeClassifierParams {
/**
*
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r41984757
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148028419
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-148028398
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r41043325
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-145087481
The implementation looks fine, except that it needs to be restricted to
DecisionTreeRegressor (until it's added for the others).
---
If your project is set up for it,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r41043331
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -214,7 +216,7 @@ private[ml] object TreeClassifierParams {
/**
* P
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r41043330
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -113,6 +114,17 @@ final class DecisionTreeRegressionModel
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-144023820
@jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142258957
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142258959
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142258718
[Test build #42828 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42828/console)
for PR 8866 at commit
[`d38e63d`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142244633
[Test build #42828 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42828/consoleFull)
for PR 8866 at commit
[`d38e63d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142244002
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8866#issuecomment-142243938
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/8866
[SPARK-9622] [ML] DecisionTreeRegressor: provide variance of prediction
DecisionTreeRegressor will provide variance of prediction as a Double
column.
You can merge this pull request into a Git r
73 matches
Mail list logo
