Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8564
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146643016
Thanks! Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146389640
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146389641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146389576
[Test build #43369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43369/console)
for PR 8564 at commit
[`7fb3b1c`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146388505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146388506
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146388370
[Test build #43367 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43367/console)
for PR 8564 at commit
[`d3021f0`](https://github.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146385212
Sure, looking at the logisticregression impl it seems that it currently
uses transform, but it doesn't do handle the case where the preidction col is
set to "", so I jus
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146385074
[Test build #43369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43369/consoleFull)
for PR 8564 at commit
[`7fb3b1c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146384813
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146384823
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146383144
[Test build #43367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43367/consoleFull)
for PR 8564 at commit
[`d3021f0`](https://gith
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146382752
Once this is merged (or now), can you please make an analogous JIRA for the
LogisticRegressionSummary? Thanks!
---
If your project is set up for it, you can reply to
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146382111
LGTM except for that style issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r41465812
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -316,13 +322,27 @@ class LinearRegressionModel private[ml] (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146380207
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146380219
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146348410
yes, thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146346494
Is this ready to review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146334357
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146334360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146333990
[Test build #43343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43343/console)
for PR 8564 at commit
[`a247aa6`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146321073
[Test build #43343 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43343/consoleFull)
for PR 8564 at commit
[`a247aa6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146320505
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146320481
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146317692
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146317690
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146317530
[Test build #43339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43339/console)
for PR 8564 at commit
[`e91cdc4`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146307711
[Test build #43339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43339/consoleFull)
for PR 8564 at commit
[`e91cdc4`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146306981
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146306928
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-146046549
Sounds good, I'll try and simplify this code when I get some spare cycles.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-145159351
This looks fine, except for some code simplifications. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r41069606
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -267,9 +277,19 @@ class LinearRegression(override val uid: Strin
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r41069608
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -179,9 +179,19 @@ class LinearRegression(override val uid: Strin
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r41069603
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -461,9 +461,22 @@ class LinearRegressionSuite extends Spar
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-144870849
ping @jkbradley now that it is updated again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r40271367
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r40114403
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r40055543
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r40040749
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141579393
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141579396
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141579035
[Test build #42694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42694/console)
for PR 8564 at commit
[`d8baa47`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141570505
[Test build #42694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42694/consoleFull)
for PR 8564 at commit
[`d8baa47`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141569091
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-141569056
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r39898676
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r39679985
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -460,6 +460,10 @@ class LinearRegressionSuite extends Spar
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r39679838
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139952739
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139952740
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139952540
[Test build #42391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42391/console)
for PR 8564 at commit
[`e633ac5`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139946260
[Test build #42391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42391/consoleFull)
for PR 8564 at commit
[`e633ac5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139945848
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-139945841
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r39115766
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -300,7 +300,7 @@ class LinearRegressionModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r39115767
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -460,6 +460,18 @@ class LinearRegressionSuite extends Spar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136960787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136960784
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136960678
[Test build #41915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41915/console)
for PR 8564 at commit
[`43420b7`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136954162
[Test build #41915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41915/consoleFull)
for PR 8564 at commit
[`43420b7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136951779
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8564#issuecomment-136951696
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/8564
[SPARK-9718][ML] linear regression training summary all columns
LinearRegression training summary: The transformed dataset should hold all
columns, not just selected ones like prediction and label.
66 matches
Mail list logo
