[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137327087 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137272142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137272144 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137272059 [Test build #41950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41950/console) for PR 8567 at commit [`bf324c4`](https://github.

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137265373 [Test build #41950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41950/consoleFull) for PR 8567 at commit [`bf324c4`](https://gith

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137264525 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137264508 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137263278 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137263277 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137263271 [Test build #41949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41949/console) for PR 8567 at commit [`0235a6a`](https://github.

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137262398 [Test build #41949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41949/consoleFull) for PR 8567 at commit [`0235a6a`](https://gith

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137261286 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137261307 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8567#discussion_r38589547 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -501,7 +501,13 @@ trait Params extends Identifiable with Serializable { */

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137244218 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137244216 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137244071 [Test build #41945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41945/console) for PR 8567 at commit [`1b502b9`](https://github.

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137231756 [Test build #41945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41945/consoleFull) for PR 8567 at commit [`1b502b9`](https://gith

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137231127 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137231099 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/8567#discussion_r38508886 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -501,7 +501,13 @@ trait Params extends Identifiable with Serializable { */

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136970128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136969922 [Test build #41918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41918/console) for PR 8567 at commit [`2f6c14d`](https://github.

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136970130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8567#discussion_r38506300 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -501,7 +501,13 @@ trait Params extends Identifiable with Serializable { */

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136959655 [Test build #41918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41918/consoleFull) for PR 8567 at commit [`2f6c14d`](https://gith

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136958005 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-136958029 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/8567 [SPARK-9723][ML] params getordefault should throw more useful error Params.getOrDefault should throw a more meaningful exception than what you get from a bad key lookup. You can merge this pull req