Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-140691256
OK this looks pretty good. @marmbrus any objections? the logic looks
reasonable as do the tests.
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r39693611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.sql.catalyst.util
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-139266586
[Test build #1736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1736/consoleFull)
for PR 8396 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-139298616
[Test build #1736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1736/console)
for PR 8396 at commit
Github user kevincox commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r38929835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -107,30 +107,21 @@ object DateTimeUtils {
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r38932293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -107,30 +107,21 @@ object DateTimeUtils {
}
Github user kevincox commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138570024
Sorry, had a busy week. I can definitely add a couple of tests. The
existing tests also verify that this is working with the previously tested
formats (assuming that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138730613
[Test build #42161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42161/consoleFull)
for PR 8396 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138729787
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138730252
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138730234
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138733112
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138733078
[Test build #42161 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42161/console)
for PR 8396 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138733114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user kevincox commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r38939186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -107,30 +107,21 @@ object DateTimeUtils {
}
Github user kevincox commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138599541
Tests added (there weren't any previously). I tried to ensure they covered
all supported cases.
---
If your project is set up for it, you can reply to this email and
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8396#issuecomment-138259475
@kevincox can you follow up on this, adding tests (or else point out the
tests I missed)? I think this deserves some basic coverage.
---
If your project is set up for
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r38078235
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -107,30 +107,21 @@ object DateTimeUtils {
}
Github user kevincox commented on a diff in the pull request:
https://github.com/apache/spark/pull/8396#discussion_r37762298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -107,30 +107,21 @@ object DateTimeUtils {
}
20 matches
Mail list logo
