[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142176933 I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142176508 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142176504 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142176259 [Test build #42800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42800/console) for PR 8832 at commit [`a643281`](https://github.

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142158656 LGTM merging once tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142158322 > if the master does not contain deploy mode information, the deploy mode is "client", else get deploy mode from the master URL. We're actually deprecatin

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142157359 [Test build #42800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42800/consoleFull) for PR 8832 at commit [`a643281`](https://gith

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142157091 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142157085 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142156938 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142063538 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142063535 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142059757 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-142059714 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-20 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141860945 @falaki , are you using RStudio, where spark-submit is not involved? I don't think we can simply set a default value. Because it is possible that the default mod

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8832#discussion_r39917344 --- Diff: core/src/main/scala/org/apache/spark/api/r/RUtils.scala --- @@ -44,7 +44,7 @@ private[spark] object RUtils { (sys.props("spark.master

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141607668 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141607670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141607465 [Test build #42699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42699/console) for PR 8832 at commit [`8b80886`](https://github.

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread falaki
Github user falaki commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141606839 Yes, if an application starts the JVM manually (not using spark-submit) this call will fail. The change just adds safety without compromising functionality or correctness

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141606486 Any reason this would not be set ? My assumption was that all spark-submit applications had this -- so I guess this is for applications not using spark-submit ?

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread falaki
Github user falaki commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141606332 cc @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141590625 [Test build #42699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42699/consoleFull) for PR 8832 at commit [`8b80886`](https://gith

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141589747 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141589739 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-18 Thread falaki
GitHub user falaki opened a pull request: https://github.com/apache/spark/pull/8832 [SPARKR][SPARK-10711] Do not assume spark.submit.deployMode is always set In ```RUtils.sparkRPackagePath()``` we 1. Call ``` sys.props("spark.submit.deployMode")``` which returns null if ```spar