[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135656017 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135655957 [Test build #41724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41724/console) for PR 8495 at commit

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135656016 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135621454 @shivaram All right. I am checking this on my local machine. Please give me some minutes. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135621545 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135621561 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135622468 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135622466 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135620819 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135620803 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8495#discussion_r38168825 --- Diff: R/pkg/R/generics.R --- @@ -413,7 +413,7 @@ setGeneric(dropna, #' @rdname nafunctions #' @export setGeneric(na.omit, --- End diff

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135625010 [Test build #41724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41724/consoleFull) for PR 8495 at commit

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135627612 Cool - lintr checks also seem to be passing now. I'll merge this once tests pass --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135641171 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/8495 [SPARKR] [SPARK-10328] Fix generic for na.omit S3 function is at https://stat.ethz.ch/R-manual/R-patched/library/stats/html/na.fail.html You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135620501 cc @yu-iskw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135641074 [Test build #41722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41722/console) for PR 8495 at commit

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135641172 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135624503 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135624510 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135621721 [Test build #41722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41722/consoleFull) for PR 8495 at commit

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135624869 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARKR] [SPARK-10328] Fix generic for na.omit

2015-08-27 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8495#issuecomment-135620933 @yu-iskw I also found a minor bug in lint-r that I just fixed. Please let me know if that is good. With this change lint-r passes on my machine --- If your project is