Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74593651
Thanks! merged to master and branch 1.3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74585177
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74585173
[Test build #27576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27576/consoleFull)
for PR 4472 at commit
[`fef0cf1`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74576851
[Test build #27576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27576/consoleFull)
for PR 4472 at commit
[`fef0cf1`](https://githu
Github user kai-zeng commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74576543
@cloud-fan Yeah, aggregates.scala is executable in spark master. And I have
made it un-executable in this PR. BTW, these files are also executable in spark
master (I chm
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74485193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74485187
[Test build #27548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27548/consoleFull)
for PR 4472 at commit
[`5a41e49`](https://gith
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74479736
`aggregates.scala` is the only file in folder `expressions` which is
executable, I think it was a mistake and we should make it un-executable.
---
If your project is s
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74479214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74479209
[Test build #27545 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27545/consoleFull)
for PR 4472 at commit
[`cb37c94`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74478946
[Test build #27548 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27548/consoleFull)
for PR 4472 at commit
[`5a41e49`](https://githu
Github user kai-zeng commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74478451
@chenghao-intel you mean revert aggregates.scala to executable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74476383
@kai-zeng can you also revert the file permission bit for
`aggregates.scala`?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user kai-zeng commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74474525
@chenghao-intel Done rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74472313
[Test build #27545 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27545/consoleFull)
for PR 4472 at commit
[`cb37c94`](https://githu
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-74463234
@kai-zeng The code LGTM, and I've tested the `Add` in an aggregation
benchmark, it shows about 20% performance improved. So can you rebase the code?
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73629671
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73629667
[Test build #27142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27142/consoleFull)
for PR 4472 at commit
[`7f6e968`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73621509
[Test build #27142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27142/consoleFull)
for PR 4472 at commit
[`7f6e968`](https://githu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73620361
Thanks for doing this. Can you undo the permission changes on the files
`100644 â 100755`. I think you made them executable.
---
If your project is set up for it, y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73538438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73538427
[Test build #27105 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27105/consoleFull)
for PR 4472 at commit
[`6cddb46`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73524507
[Test build #27105 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27105/consoleFull)
for PR 4472 at commit
[`6cddb46`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73523672
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73523669
[Test build #27104 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27104/consoleFull)
for PR 4472 at commit
[`7490dbc`](https://gith
Github user kai-zeng commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73523394
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73523508
[Test build #27104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27104/consoleFull)
for PR 4472 at commit
[`7490dbc`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73513591
[Test build #27103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27103/consoleFull)
for PR 4472 at commit
[`7490dbc`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73513477
[Test build #27103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27103/consoleFull)
for PR 4472 at commit
[`7490dbc`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73513595
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73510687
[Test build #27102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27102/consoleFull)
for PR 4472 at commit
[`9c40bc0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73510697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73505392
[Test build #27102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27102/consoleFull)
for PR 4472 at commit
[`9c40bc0`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73501771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73501760
[Test build #27101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27101/consoleFull)
for PR 4472 at commit
[`3cbd363`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4472#issuecomment-73500659
[Test build #27101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27101/consoleFull)
for PR 4472 at commit
[`3cbd363`](https://githu
GitHub user kai-zeng opened a pull request:
https://github.com/apache/spark/pull/4472
[SQL] Optimize arithmetic and predicate operators
Existing implementation of arithmetic operators and BinaryComparison
operators have redundant type checking codes, e.g.:
Expression.n2 is used
38 matches
Mail list logo
