[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195794904 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195794898 Did you already create a JIRA ticket, or you still need to create one? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195779128 Hi, @liancheng . Sorry for leaving a message here. Could you review #11675 if you have some time? It's a supplement update for your replacing `DataFrame`

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195768441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195768439 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195768223 **[Test build #53005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53005/consoleFull)** for PR 11678 at commit [`e789893`](https://g

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195750222 **[Test build #53005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53005/consoleFull)** for PR 11678 at commit [`e789893`](https://gi

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195742009 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195741650 **[Test build #53001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53001/consoleFull)** for PR 11678 at commit [`97a62d6`](https://g

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195742004 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195727233 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195727234 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195727222 **[Test build #53000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53000/consoleFull)** for PR 11678 at commit [`440ddd1`](https://g

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195726312 **[Test build #53001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53001/consoleFull)** for PR 11678 at commit [`97a62d6`](https://gi

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195725587 **[Test build #53000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53000/consoleFull)** for PR 11678 at commit [`440ddd1`](https://gi

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11678#issuecomment-195725432 ASF JIRA down, will add JIRA number to the PR title later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SQL] Removes Dataset.collectRows()/takeRows()

2016-03-12 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/11678 [SQL] Removes Dataset.collectRows()/takeRows() ## What changes were proposed in this pull request? This PR removes two methods, `collectRows()` and `takeRows()`, from `Dataset[T]`. These