Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67288934
Not a problem at all. Just wanted to know to see if I need to patch our own
1.2 release.
Thank you Cheng, Josh, and Michael for the prompt actions to get the pull
th
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67287991
@judynash Unfortunately we've already cut 1.2.0 RC2 (which is now
officially 1.2.0 release) before this PR was submitted, so it will be part of
1.2.1. And sorry for all
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67274367
Michael â thanks for checking in! Will this be part of 1.2 as well?
Wondering since I didnât see the merge on branch 1.2.
From: Michael Armbrust [mai
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67227330
LGTM, thanks for working on this! Merging to master and 1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67222875
I don't really know anything about the thriftserver, so I'm not comfortable
merging this PR myself. Therefore, let's ping @marmbrus for a final sign-off +
commit.
--
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67220291
Thanks Cheng and Josh for restarting the tests! What's the next step now
the test has passed?
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67120867
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67120862
[Test build #24483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24483/consoleFull)
for PR 3672 at commit
[`526315d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67113736
[Test build #24483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24483/consoleFull)
for PR 3672 at commit
[`526315d`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67113444
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67105422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67105417
[Test build #24477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24477/consoleFull)
for PR 3672 at commit
[`526315d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67097904
[Test build #24477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24477/consoleFull)
for PR 3672 at commit
[`526315d`](https://githu
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-67097621
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66950036
Thank you Cheng for the update.
From: Cheng Lian [mailto:notificati...@github.com]
Sent: Sunday, December 14, 2014 6:57 PM
To: apache/spark
Cc: Judy N
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66944216
The most recent test failures should be caused by other components. Let's
wait for a moment. This PR now LGTM.
---
If your project is set up for it, you can reply to t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66936452
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66936450
[Test build #2 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/2/consoleFull)
for PR 3672 at commit
[`526315d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66933007
[Test build #2 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/2/consoleFull)
for PR 3672 at commit
[`526315d`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66919314
[Test build #24440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24440/consoleFull)
for PR 3672 at commit
[`31a6520`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66919317
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66916267
[Test build #24440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24440/consoleFull)
for PR 3672 at commit
[`31a6520`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66916125
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66854192
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66854184
[Test build #24420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24420/consoleFull)
for PR 3672 at commit
[`31a6520`](https://gith
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66843978
Fixed the styling issue and generated SQL Programming Guide doc. See
screenshot http://i.imgur.com/l9F4mXq.png
---
If your project is set up for it, you can reply to t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66843487
[Test build #24420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24420/consoleFull)
for PR 3672 at commit
[`31a6520`](https://githu
Github user judynash commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21774497
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Yo
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729377
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729186
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66733569
Did a double check and spotted a few more minor styling issues. This PR
should be ready to go once those issue are fixed. Thanks!
---
If your project is set up for it,
Github user judynash commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729137
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Yo
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729067
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -140,7 +160,8 @@ class HiveThrift
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729057
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,15 +128,28 @@ class HiveThri
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729040
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -70,11 +70,17 @@ class HiveThrift
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729017
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -85,10 +86,22 @@ private[hive] class H
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21728999
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21728960
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66731361
[Test build #24389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24389/consoleFull)
for PR 3672 at commit
[`2e9c11c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66731363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726073
I have addressed the feedbacks (thank you Cheng!) and added documentation.
Let me know if there is anything else. Thanks again!
---
If your project is set up for it, yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726017
[Test build #24385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24385/consoleFull)
for PR 3672 at commit
[`2b1d312`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66725464
[Test build #24389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24389/consoleFull)
for PR 3672 at commit
[`2e9c11c`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66721275
[Test build #24385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24385/consoleFull)
for PR 3672 at commit
[`2b1d312`](https://githu
46 matches
Mail list logo
