Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-114325488
Thanks for working on this, but I think we should probably close this issue
in favor of the implementation in #6297.
---
If your project is set up for it, you can repl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-101970493
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r29737910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -616,6 +617,119 @@ case class SumFunction(expr: Expres
Github user dreamquster commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-95611837
@yhuai . Is this comment OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94413583
[Test build #30578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30578/consoleFull)
for PR 5357 at commit
[`1052218`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94413601
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94383918
[Test build #30578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30578/consoleFull)
for PR 5357 at commit
[`1052218`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94379206
[Test build #30577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30577/consoleFull)
for PR 5357 at commit
[`c61d535`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94379211
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94379026
[Test build #30577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30577/consoleFull)
for PR 5357 at commit
[`c61d535`](https://githu
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94240966
@dreamquster Can you add comments in your code to explain:
1. Is it sample standard deviation or population standard deviation?
2. What is the algorithm used to
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-94024412
@dreamquster thanks for doing this -- I think we also need to add the
Python version of it here as well.
@yhuai can you review the stddev expression code itself?
-
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r28609928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -616,6 +617,115 @@ case class SumFunction(expr: Expressi
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r28609773
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -344,6 +344,20 @@ object functions {
*/
def abs(e: Column): Column =
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r28609709
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -344,6 +344,20 @@ object functions {
*/
def abs(e: Column): Column =
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r28609646
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -344,6 +344,20 @@ object functions {
*/
def abs(e: Column): Column =
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5357#discussion_r28609608
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -334,6 +334,24 @@ class DataFrameSuite extends QueryTest {
Row(new
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93868139
/cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93845448
[Test build #30432 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30432/consoleFull)
for PR 5357 at commit
[`a012fc3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93845459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93826615
[Test build #30432 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30432/consoleFull)
for PR 5357 at commit
[`a012fc3`](https://githu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93825495
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-93655610
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user dreamquster reopened a pull request:
https://github.com/apache/spark/pull/5357
[SQL] SPARK-6548: Adding stddev to DataFrame functions
remerge SPARK-6548
https://github.com/apache/spark/pull/5228
You can merge this pull request into a Git repository by running:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-91108793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-91108787
[Test build #29915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29915/consoleFull)
for PR 5357 at commit
[`a012fc3`](https://gith
Github user dreamquster commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-89980788
What's wrong?Who can verify it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5357#issuecomment-89527728
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user dreamquster opened a pull request:
https://github.com/apache/spark/pull/5357
[SQL] SPARK-6548: Adding stddev to DataFrame functions
remerge SPARK-6548
https://github.com/apache/spark/pull/5228
You can merge this pull request into a Git repository by running:
$
30 matches
Mail list logo
