Github user egraldlo commented on a diff in the pull request:
https://github.com/apache/spark/pull/1190#discussion_r14230460
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -65,7 +64,7 @@ private[sql] abstract class SparkStrategies
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47296481
Thanks, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47296531
Oh, code conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47296613
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47296622
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47301406
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16177/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47301403
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47301657
Thanks, merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47063650
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16104/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47063649
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47176944
I'm not sure what the point of this change is. It is only serving to make
the planner more brittle and tied to the specifics of the current
implementation of the
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47177647
The `join/where` predicate push down has been done in
`PushPredicateThroughJoin` of the logical plan optimizer, I don't think we
really need to do it again here.
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47177931
BTW, if I follow the current implementation pattern, which also mean I have
to add filter for the outer join, too, which may make the code duplicated(with
the
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47179834
Okay, you've convinced me with the outer join argument. Remove
HashFilteredJoin as its pretty redundant with your pattern.
---
If your project is set up for it, you
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47179857
and please rebase to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47183740
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47183743
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47183791
Thank you @marmbrus , updated, let's see the testing result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47187502
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16136/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47187501
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/1190#discussion_r14114281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -160,6 +160,43 @@ object HashFilteredJoin extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46939722
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16049/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46939721
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46941093
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46941097
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46949376
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46949382
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16051/
---
If your project is set up for it, you can
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47059380
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47059507
@rxin , can you ask Jenkins to retest this? Seems he doesn't answer me. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47059529
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47059533
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-47059590
Oh, Jenkins is working. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46934462
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1190#issuecomment-46934466
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1190#discussion_r14114049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -160,6 +160,43 @@ object HashFilteredJoin extends
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1190#discussion_r14114058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -160,6 +160,43 @@ object HashFilteredJoin extends
37 matches
Mail list logo
