Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-178820992
Hi Josh, do you see any problem? The Jenkins should have it tested and its
clean to be merged be now
---
If your project is set up for it, you can reply to this
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51035587
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -469,6 +469,13 @@ class JDBCSuite extends SparkFunSuite with
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51035933
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -88,7 +101,8 @@ private[sql] case class
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51036047
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -108,6 +122,6 @@ private[sql] case class
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51036461
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -37,6 +37,9 @@ private[sql] case class
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-175818906
Yes, all comments resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51038017
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-175203838
Hey, there's still a bunch of review comments that I left which haven't
been acknowledged or addressed! Mind replying to them?
---
If your project is set up for it,
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-174732217
Good! Boots on the ground.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-174732645
Rebased with minimal changes to code style (and reverted whitespace changes
as well as correcting import order). All tests passed. Let's finish this
---
If your
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r50641262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -37,6 +37,9 @@ private[sql] case class
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168621202
Hm @tribbloid this now fails a test on the JDBC drivers:
```
[info] Exception encountered when attempting to run a suite with class
name:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715771
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715834
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -37,6 +37,9 @@ private[sql] case class
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715673
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715790
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48714853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/DriverRegistry.scala
---
@@ -57,4 +57,3 @@ object DriverRegistry extends
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715367
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -108,6 +122,6 @@ private[sql] case class
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48714897
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -469,6 +469,13 @@ class JDBCSuite extends SparkFunSuite with
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -88,7 +101,8 @@ private[sql] case class
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168622897
I think this PR would be much easier to test after #10519 is fixed, in case
any reviewers here would also like to look at my PR.
---
If your project is set up for
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +76,19 @@ private[sql] object
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715580
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48789707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -37,6 +37,9 @@ private[sql] case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168491449
**[Test build #2301 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2301/consoleFull)**
for PR 8785 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168493283
**[Test build #2301 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2301/consoleFull)**
for PR 8785 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168493407
**[Test build #2304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2304/consoleFull)**
for PR 8785 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168494148
**[Test build #2304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2304/consoleFull)**
for PR 8785 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168313849
Weird, OK. This LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48678521
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168148505
**[Test build #2280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2280/consoleFull)**
for PR 8785 at commit
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168211061
Looks like the removed qualifier of Map in JDBCRelation has caused build to
fail (Map is cast to immutable.Map). I'm adding back the qualifier
scala.collection.Map
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168148300
**[Test build #2280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2280/consoleFull)**
for PR 8785 at commit
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48636488
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-168087181
I'm so done with IntelliJ autocorrection. But all fixed, thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-167978930
@tribbloid still having some issue with the style checker:
```
[error]
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-167539588
**[Test build #2258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2258/consoleFull)**
for PR 8785 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-167539724
**[Test build #2258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2258/consoleFull)**
for PR 8785 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48472434
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48492460
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48489063
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48460773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48460762
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user tribbloid closed the pull request at:
https://github.com/apache/spark/pull/8785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-167461046
All issues should be fixed by now, submitting final pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user tribbloid reopened a pull request:
https://github.com/apache/spark/pull/8785
[Spark-10625] [SQL] Spark SQL JDBC read/write is unable to handle JDBC
Drivers that adds unserializable objects into connection properties
Connection properties are now deep copied before they
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48460893
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48460878
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-166854056
@tribbloid let's wrap this up at last. Can you please review all the
outstanding comments and address them or else close this?
---
If your project is set up for it, you
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-167015238
Of course Dr. I'll finish reading in a few hours.
Yours Peng
On 15-12-23 05:10 AM, Sean Owen wrote:
>
> @tribbloid
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194955
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194924
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194995
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48195057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object JDBCRelation
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-166392614
Sorry I misunderstood your intention on previous comments, now both problem
should be fixed: toSeq is removed and single line of code in brackets are
pulled up.
---
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-165577580
@tribbloid I think there are still some little style comments in
`UnserializableDriverHelper`
---
If your project is set up for it, you can reply to this email and have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-165099839
I think this is looking good otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47773368
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +75,18 @@ private[sql] object JDBCRelation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47773335
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47790709
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +75,18 @@ private[sql] object
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-165147353
Good, thanks a lot for advices.
This should be the last patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47730716
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -88,7 +100,11 @@ private[sql] case class
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47730785
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47730829
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-164968520
Thanks a lot! All addressed. Sorry I was distracted from this ticket for 2
days
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47730696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +75,18 @@ private[sql] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47206801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +76,19 @@ private[sql] object JDBCRelation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47206871
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +75,18 @@ private[sql] object JDBCRelation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47207033
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47206961
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -88,7 +100,11 @@ private[sql] case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r47207095
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-163455378
@srowen Sorry you are right, there is already a deep copy and I should just
use that, will correct immediately
---
If your project is set up for it, you can reply to
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-163455429
done! Thanks a lot for pointing it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-162604858
@srowen yeah, I'll reply shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-162701698
@srowen thanks a lot for posting the problem in import declarations, I've
already correct it and won't optimize import habitually.
---
If your project is set up for
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-162703442
@srowen for you second question: the connection property is deep copied
twice to ensure that the original object is immutable. Reverting it breaks the
scenario where
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-162705458
I don't get that -- what does the original object matter if it's copied
here? and how would the copy change?
---
If your project is set up for it, you can reply to
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-162213600
@tribbloid are you still working on this? I had an outstanding question or
two here
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r46122352
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -20,12 +20,11 @@ package org.apache.spark.sql.jdbc
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r46122485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -303,7 +298,8 @@ final class DataFrameWriter private[sql](df: DataFrame)
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10020#issuecomment-160265026
This should be closed and be part of
https://github.com/apache/spark/pull/8785 or else I'm unclear on the
difference? Let's put the change in one place please.
---
If
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/10020#issuecomment-160333704
sorry its just a squashed commit, I speculate that PMC will squash rebase
it anyway but I'm not so sure, so I requested 2 identical patches
---
If your project is
Github user tribbloid closed the pull request at:
https://github.com/apache/spark/pull/10020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r46041751
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -280,7 +275,8 @@ final class DataFrameWriter private[sql](df: DataFrame)
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-160127622
I guess I'm missing why a deep copy solves a problem of an unserializable
property value. It still exists in the copy right?
---
If your project is set up for it, you
GitHub user tribbloid opened a pull request:
https://github.com/apache/spark/pull/10020
[Spark-10625] [SQL] Spark SQL JDBC read/write is unable to handle JDBC
Drivers that adds unserializable objects into connection properties
this pull request has several commits squashed together
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10020#issuecomment-160206949
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-160162604
Hi Sean, the property value can only be mutated by JDBC driver's function
to fetch the schema on Spark driver, after which it's no longer serializable.
My deep copy
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-142306277
PR fixed as well, thanks a lot Holden!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
89 matches
Mail list logo
