[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197553310 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197554122 LGTM Merging with master Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197536524 other than that 1 item, this looks ready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread GayathriMurali
Github user GayathriMurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11707#discussion_r56410885 --- Diff: python/pyspark/ml/tests.py --- @@ -499,6 +499,24 @@ def test_linear_regression(self): except OSError: pass

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197419373 @jkbradley Please let me know if I can do anything else to help this get merged. --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197606615 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197606612 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197553002 **[Test build #53349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53349/consoleFull)** for PR 11707 at commit [`dd42a00`](https://g

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197606049 **[Test build #53348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53348/consoleFull)** for PR 11707 at commit [`8463285`](https://g

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197546550 **[Test build #53348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53348/consoleFull)** for PR 11707 at commit [`8463285`](https://gi

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11707#discussion_r56409504 --- Diff: python/pyspark/ml/tests.py --- @@ -499,6 +499,24 @@ def test_linear_regression(self): except OSError: pass

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197548293 **[Test build #53349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53349/consoleFull)** for PR 11707 at commit [`dd42a00`](https://gi

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-197553313 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678560 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678561 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678381 **[Test build #53164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53164/consoleFull)** for PR 11707 at commit [`139dd2a`](https://g

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196675600 **[Test build #53164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53164/consoleFull)** for PR 11707 at commit [`139dd2a`](https://gi

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-14 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196675209 @jkbradley Fixed all the minor issues and changed title. Will wait for the tests to complete --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11707#discussion_r56108634 --- Diff: python/pyspark/ml/classification.py --- @@ -69,8 +69,20 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredicti

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196625881 Just a few small comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11707#discussion_r56108637 --- Diff: python/pyspark/ml/classification.py --- @@ -709,6 +733,7 @@ class MultilayerPerceptronClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol,

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196622560 Thanks @GayathriMurali While tests are running, could you please fix the title to have "[SPARK-13034]" (with a hyphen)? I'll take a look at this. --- If your proj

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196587994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196587992 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196587911 **[Test build #53140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53140/consoleFull)** for PR 11707 at commit [`00f69f1`](https://g

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196585202 **[Test build #53140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53140/consoleFull)** for PR 11707 at commit [`00f69f1`](https://gi

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196584946 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196577646 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196577119 @jkbradley I closed the earlier PR and created a new one here. This one adds persistence to LogisticRegression and NaiveBayes. @wangmiao1981 Please review th

[GitHub] spark pull request: [Spark 13034] PySpark ml.classification suppor...

2016-03-14 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/11707 [Spark 13034] PySpark ml.classification support export/import ## What changes were proposed in this pull request? Add export/import for all estimators and transformers(which have Sca