Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215760710
@GayathriMurali I sent #12778 for ```glm``` and ```kmeans``` persistence,
please feel free to review and comments. Thanks!
---
If your project is set up for it, you
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215638319
I'm glad to help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215631757
@GayathriMurali Since the feature freeze deadline is coming and there are
some follow-up tasks blocked by this PR and #12683, do you mind @yanboliang
sending out new PRs
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61370311
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -152,6 +152,18 @@ test_that("kmeans", {
expect_equal(sort(collect(distinct(select(cluster,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61342771
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala ---
@@ -17,14 +17,21 @@
package org.apache.spark.ml.r
+impor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215239652
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215239612
**[Test build #57176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57176/consoleFull)**
for PR 12680 at commit
[`616a485`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215239651
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215234447
@yanboliang Please LGTM if the changes look good to you:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215230898
**[Test build #57176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57176/consoleFull)**
for PR 12680 at commit
[`616a485`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-215230556
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61066560
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala ---
@@ -17,14 +17,21 @@
package org.apache.spark.ml.r
+import
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61066043
--- Diff: R/pkg/R/mllib.R ---
@@ -243,6 +243,54 @@ setMethod("kmeans", signature(x = "SparkDataFrame"),
return(new("KMeansModel", jobj = j
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61065541
--- Diff: R/pkg/R/mllib.R ---
@@ -243,6 +243,54 @@ setMethod("kmeans", signature(x = "SparkDataFrame"),
return(new("KMeansModel", jobj = j
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61026788
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala ---
@@ -17,14 +17,21 @@
package org.apache.spark.ml.r
+impor
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12680#discussion_r61025886
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala ---
@@ -17,14 +17,21 @@
package org.apache.spark.ml.r
+impor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12680#issuecomment-214593821
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user GayathriMurali opened a pull request:
https://github.com/apache/spark/pull/12680
[Spark-14314][SparkR] Add model persistence to KMeans
## What changes were proposed in this pull request?
Add model persistence to KMeans SparkR
## How was this patch t
19 matches
Mail list logo
