Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218536015
@yhuai Could you please add @xwu0226 into the whitelist? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218534734
In future, let's trigger another jenkins run for this kind of PRs :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218533538
@dongjoon-hyun @yhuai Thanks for fixing it!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218524269
I have merged #13053.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218518068
Hi, @xwu0226 and @liancheng .
There occurs build errors. I made a hotfix for this. Please merge that.
#13053
---
If your project is set up for it, you can
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218494987
@liancheng Thank you!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218472375
LGMT, merging to master and branch-2.0. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62855376
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -741,4 +741,28 @@ class LogicalPlanToSQLSuite extends S
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-218232688
cc @hvanhovell @yhuai @liancheng All the comments are addressed. Please
see if there is anything else. Thanks!
---
If your project is set up for it, you can reply to
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62270486
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -741,4 +741,28 @@ class LogicalPlanToSQLSuite extends SQL
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217264815
@liancheng I added the create view
[testcases](https://github.com/xwu0226/spark/blob/SPARK_14933/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217207511
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217207508
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217207287
**[Test build #57896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57896/consoleFull)**
for PR 12716 at commit
[`e653db4`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217190024
**[Test build #57896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57896/consoleFull)**
for PR 12716 at commit
[`e653db4`](https://gi
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217173378
@liancheng Thanks for your input! I will add the create view testcase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217122939
My major concern is about the test cases. The main changes looks good
though. Thanks for working on this!
---
If your project is set up for it, you can reply to this
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62172010
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -741,4 +741,28 @@ class LogicalPlanToSQLSuite extends S
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62171092
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -741,4 +741,28 @@ class LogicalPlanToSQLSuite extends S
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62120329
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -295,7 +295,10 @@ private[hive] class HiveMetastoreCatalog(spar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217001627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217001624
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-217001360
**[Test build #57791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57791/consoleFull)**
for PR 12716 at commit
[`704a9eb`](https://g
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12716#discussion_r62112161
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -295,7 +295,10 @@ private[hive] class HiveMetastoreCatalog(s
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-216984717
**[Test build #57791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57791/consoleFull)**
for PR 12716 at commit
[`704a9eb`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-216984438
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-216749038
@yhuai @liancheng @liancheng @hvanhovell Can any of you help taking a quick
look at this change? Thank you very much!
---
If your project is set up for it, you can rep
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-214909447
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/12716#issuecomment-214909072
@liancheng I hit this issue when I tied to create a testcase for the `show
create table` PR. So I created a separate PR to address this issue. Please help
take a look i
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/12716
[Spark-14933][SQL] Failed to create view out of a parquet or orc table
## What changes were proposed in this pull request?
If a table is created as parquet or ORC table with hive syntaxt DDL, su
31 matches
Mail list logo
