[GitHub] spark pull request: [Spark 2381] stop the streaming application if...

2014-07-31 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-50796342 Can you please add unit test for this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark 2381] stop the streaming application if...

2014-08-01 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-50933873 Also could you change the title to contain "SPARK-2381" (withi -) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-05 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-54679164 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-05 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-54679375 @joyyoj Can you please add an unit test for this behavior in the StremaingContextSuite, this is a significant change in the program behavior and should have a unit test.

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-05 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/1693#discussion_r17197213 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -272,7 +272,15 @@ class ReceiverTracker(ssc: StreamingConte

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-05 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/1693#discussion_r17197419 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -272,7 +272,15 @@ class ReceiverTracker(ssc: StreamingConte

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-54694532 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-09-25 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-56858048 @joyyoj any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [Spark 2381] stop the streaming application if...

2014-08-04 Thread joyyoj
Github user joyyoj commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-51146846 Ok, I'll do it soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-11-07 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/1693#issuecomment-6999 @joyyoj If you are unable to address the comments on this PR, mind closing this? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-11-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/1693#discussion_r20042431 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -272,7 +272,15 @@ class ReceiverTracker(ssc: StreamingCon

[GitHub] spark pull request: [Spark-2381] stop the streaming application if...

2014-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab