Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-128152607
Ohh, right. I need to read more carefully...
I'll watch that JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-128135582
Wait @jkbradley its actually only implemented on StringIndexerModel which
is where it belongs, but it just was not add it to the PySpark API. I could add
it to the Strin
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-128132943
@jkbradley for sure :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-128130195
It's failing because invert is only in StringIndexer, not
StringIndexerModel.
That's a good point though; we should probably add invert() to
StringIndexerModel as
Github user billhao commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-128125172
I built the master branch on my cluster yesterday and was trying to use the
feature added in this pull request in PySpark. But I got an error message from
the following
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126882603
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126863297
[Test build #1266 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1266/console)
for PR 6339 at commit
[`7cdf915`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126859401
[Test build #1266 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1266/consoleFull)
for PR 6339 at commit
[`7cdf915`](https://git
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126857875
LGTM once we get the tests working
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126821738
[Test build #39255 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39255/console)
for PR 6339 at commit
[`7cdf915`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126821774
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126790700
[Test build #39255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39255/consoleFull)
for PR 6339 at commit
[`7cdf915`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126789641
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126789616
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126789073
@jkbradley should have the changes you asked for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126788834
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126788732
[Test build #39253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39253/console)
for PR 6339 at commit
[`b9cffb6`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126779537
[Test build #39253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39253/consoleFull)
for PR 6339 at commit
[`b9cffb6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126779271
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126779251
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126596584
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126596472
[Test build #39183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39183/console)
for PR 6339 at commit
[`6a38edb`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126593388
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126593370
[Test build #39182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39182/console)
for PR 6339 at commit
[`9e241d8`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126589125
[Test build #39183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39183/consoleFull)
for PR 6339 at commit
[`6a38edb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126588919
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126588901
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126588482
[Test build #39182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39182/consoleFull)
for PR 6339 at commit
[`9e241d8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126587952
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126587923
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126581074
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126581024
[Test build #39166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39166/console)
for PR 6339 at commit
[`64dd3a3`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126576143
[Test build #39166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39166/consoleFull)
for PR 6339 at commit
[`64dd3a3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126575018
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126575058
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126530650
ok, will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126530355
Since the public API can't use Option, I'd prefer we just stick with an
empty array. Users should not really even need to set it to an empty array
since that will be
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126528382
Ok! If instead of null would it be ok to use option and have the setter set
as Some()? I feel like using an empty array as the default value is pretty
ugly, but I unders
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126527947
@holdenk The remaining issues are:
* Add explanation to doc which is built into the labels Param. (Explain
that, if labels are not given, they will be taken from th
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126527694
I don't think there are enough use cases for a general invert/unapply. If
more real use cases come up, we can revisit this.
---
If your project is set up for it, you
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126519222
Are we going to have `invert` or `unapply` in the `Transformer` trait? In
scala, there is an extractor pattern
http://docs.scala-lang.org/tutorials/tour/extractor-objects
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35842843
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,94 @@ class StringIndexerModel private[ml] (
val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35842818
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,91 @@ class StringIndexerModel private[ml] (
val
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126191453
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126191293
[Test build #38991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38991/console)
for PR 6339 at commit
[`a60c0e3`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126184196
[Test build #38991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38991/consoleFull)
for PR 6339 at commit
[`a60c0e3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126184042
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126184048
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35838221
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,91 @@ class StringIndexerModel private[ml] (
val co
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126170295
Those are the only remaining items I see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35835546
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,91 @@ class StringIndexerModel private[ml] (
val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35835547
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,91 @@ class StringIndexerModel private[ml] (
val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35835545
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,91 @@ class StringIndexerModel private[ml] (
val
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126143272
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126143221
[Test build #38923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38923/console)
for PR 6339 at commit
[`1987b95`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126142434
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126142394
[Test build #38920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38920/console)
for PR 6339 at commit
[`71e8d66`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133997
[Test build #38923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38923/consoleFull)
for PR 6339 at commit
[`1987b95`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133786
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133807
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133432
[Test build #38920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38920/consoleFull)
for PR 6339 at commit
[`71e8d66`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133205
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126133228
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126131810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35825609
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -37,6 +37,7 @@ private[shared] object SharedParamsCodeGen
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126131650
[Test build #38907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38907/console)
for PR 6339 at commit
[`8450d0b`](https://github.
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35825613
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,82 @@ class StringIndexerModel private[ml] (
val
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126124720
[Test build #38907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38907/consoleFull)
for PR 6339 at commit
[`8450d0b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126124463
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126124438
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126120928
That's my only comment; the other changes look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35821577
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35821538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +152,79 @@ class StringIndexerModel private[ml] (
val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35821343
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126115073
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126114966
[Test build #38889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38889/console)
for PR 6339 at commit
[`868b1a9`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126106910
[Test build #38889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38889/consoleFull)
for PR 6339 at commit
[`868b1a9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126106580
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126106557
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126105993
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126105907
[Test build #38883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38883/console)
for PR 6339 at commit
[`5aa38bf`](https://github.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35815819
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126096436
[Test build #38883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38883/consoleFull)
for PR 6339 at commit
[`5aa38bf`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126096082
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126096052
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35809212
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35808990
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35808042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126085317
The only issue I see now is the "labelsCol" discussion above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35807130
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35806884
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35803031
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126061659
[Test build #38870 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38870/console)
for PR 6339 at commit
[`f3e0c64`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126061663
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126060573
[Test build #38870 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38870/consoleFull)
for PR 6339 at commit
[`f3e0c64`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126060374
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126060399
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35797652
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val co
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6339#discussion_r35796647
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -151,4 +153,77 @@ class StringIndexerModel private[ml] (
val
1 - 100 of 188 matches
Mail list logo