[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139607779 LGTM. Merging with master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-11 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139576624 @jkbradley Updated according to the comments. Thanks for helping review. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139108495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139108493 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139108431 [Test build #42237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42237/console) for PR 7150 at commit [`9785b56`](https://github.

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139106608 [Test build #42237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42237/consoleFull) for PR 7150 at commit [`9785b56`](https://gith

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139106516 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139106510 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-139033240 @hhbyyh Can you please fix the merge conflicts? I have time to get this merged now. Thanks! --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7150#discussion_r39089963 --- Diff: python/pyspark/ml/feature.py --- @@ -1291,6 +1291,96 @@ class RFormulaModel(JavaModel): """ +@inherit_doc +class MinMa

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-09-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7150#discussion_r39089957 --- Diff: python/pyspark/ml/feature.py --- @@ -1291,6 +1291,96 @@ class RFormulaModel(JavaModel): """ +@inherit_doc +class MinMa

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132448713 @jkbradley Sorry for the late update. I got some internet issues and cannot install Sphinx for now, so I simplified the comments. Let me know if it's not clear enough.

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132441405 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132441407 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132441355 [Test build #41206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41206/console) for PR 7150 at commit [`7b97e6a`](https://github.

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132440101 [Test build #41206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41206/consoleFull) for PR 7150 at commit [`7b97e6a`](https://gith

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132439906 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-132439897 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-130778097 Hm, the generated doc also looks odd b/c of the Latex not being render as Latex. Does the math markup element work? [http://sphinx-doc.org/ext/math.html] https://c

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7150#discussion_r37000954 --- Diff: python/pyspark/ml/feature.py --- @@ -1030,6 +1030,87 @@ class Word2VecModel(JavaModel): """ +@inherit_doc +class MinMa

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-130770624 This looks good, except for those tiny items & merge conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7150#discussion_r37000959 --- Diff: python/pyspark/ml/feature.py --- @@ -1030,6 +1030,87 @@ class Word2VecModel(JavaModel): """ +@inherit_doc +class MinMa

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7150#discussion_r37000951 --- Diff: python/pyspark/ml/feature.py --- @@ -24,7 +24,7 @@ __all__ = ['Binarizer', 'HashingTF', 'IDF', 'IDFModel', 'NGram', 'Normalizer', 'OneHotEnco

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-08-13 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-130768944 reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-121071179 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-117496677 [Test build #36235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36235/console) for PR 7150 at commit [`77f57ef`](https://github.

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-117496712 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-117492086 [Test build #36235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36235/consoleFull) for PR 7150 at commit [`77f57ef`](https://gith

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-117491162 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7150#issuecomment-117491244 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-8530] [ML] add python API for MinMaxSca...

2015-06-30 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/7150 [Spark-8530] [ML] add python API for MinMaxScaler jira: https://issues.apache.org/jira/browse/SPARK-8530 as titled. jira for MinMaxScaler: https://issues.apache.org/jira/browse/SPARK-751