Github user YanTangZhai closed the pull request at:
https://github.com/apache/spark/pull/1854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-55254070
@jkbradley I will close this PR. Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-55061571
@YanTangZhai Hi, I was asked to check out this PR. It looks like it may
no longer be necessary since stages are now paired with attempt IDs. Could you
please try run
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51884838
QA results for PR 1854:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51881015
QA tests have started for PR 1854. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18364/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51610426
QA results for PR 1854:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51604647
Please review again, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1854#discussion_r15993719
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -84,8 +84,11 @@ class JobProgressListener(conf: SparkConf) extends
Spa
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51604210
QA tests have started for PR 1854. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18202/consoleFull
---
If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51602933
@YanTangZhai Ah good point. Well, I think your original change is actually
OK then after all that. It might be more optimal to try to remove up to N
*inactive* stages from
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51601604
@srowen The stage 10 will be removed from stageIdToData later. Since it
will be added into completedStages or failedStages again and will be removed
from activeStages
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51599157
@YanTangZhai I'm not sure I wrote that clearly. I should say that the
behavior you have here could be correct if it's fine that a call to remove some
elements merely remov
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51597142
@srowen I see, thanks. I will modify.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51596179
@YanTangZhai Yes, that's fine. The code in this case would just try to
remove 10 from `stageIdToData` several times, which is a bit redundant but
harmless.
My fir
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51595260
@srowen The completedStages may contains stages as follows ...10, 10, 10,
10, 10, 11, 18... and the activeStages may contains 1, 10, 5 with unique 10
and the stageId
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51594917
QA results for PR 1854:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1854#discussion_r15989111
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -84,7 +84,11 @@ class JobProgressListener(conf: SparkConf) extends
Spa
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1854#discussion_r15989065
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -84,7 +84,11 @@ class JobProgressListener(conf: SparkConf) extends
Spa
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1854#discussion_r15989068
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -84,7 +84,11 @@ class JobProgressListener(conf: SparkConf) extends
Spa
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51591214
QA tests have started for PR 1854. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18201/consoleFull
---
If
GitHub user YanTangZhai opened a pull request:
https://github.com/apache/spark/pull/1854
[Spark 2643] Stages web ui has ERROR when pool name is None
14/07/23 16:01:44 WARN servlet.ServletHandler: /stages/
java.util.NoSuchElementException: None.get
at scala.None$.get(Option.sc
21 matches
Mail list logo
