[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966824 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966822 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966602 **[Test build #46773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46773/consoleFull)** for PR 9939 at commit [`3fb1cda`](https://git

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159959748 **[Test build #46773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46773/consoleFull)** for PR 9939 at commit [`3fb1cda`](https://gith

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159958910 This should be all for visibility review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45995982 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -407,7 +407,7 @@ private object BisectingKMeans extends Serializa

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45989271 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala --- @@ -105,7 +105,7 @@ object PCA extends DefaultParamsReadable[PCA] { @Experimental

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45900994 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Sin

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45815661 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Since

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45784933 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala --- @@ -105,7 +105,7 @@ object PCA extends DefaultParamsReadable[PCA] { @Experiment

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45784681 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Sin

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45784436 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -407,7 +407,7 @@ private object BisectingKMeans extends Serial

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45784271 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala --- @@ -44,7 +44,7 @@ class SQLTransformer @Since("1.6.0") (override val uid

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159350262 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159350199 **[Test build #46610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46610/consoleFull)** for PR 9939 at commit [`e73918d`](https://git

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159350265 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159339416 **[Test build #46610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46610/consoleFull)** for PR 9939 at commit [`e73918d`](https://gith

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45761757 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala --- @@ -44,7 +44,7 @@ class SQLTransformer @Since("1.6.0") (override val uid:

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/9939 [WIP][SPARK-11602] [MLlib] Refine visibility for 1.6 scala API audit jira: https://issues.apache.org/jira/browse/SPARK-11602 Made a pass on the API change of 1.6. Open the PR for efficient d