[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2015-02-19 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-75181287 Yeah, will do, thanks a lot :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2015-02-19 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-75160394 Ah yeah, great point. @jerryshao mind updating the title? I don't have access. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-75159502 I see. By the way in general it's good to remove the `WIP` in the title if it is no longer so to encourage reviewers look at this closely. --- If your project is set

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2015-02-19 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-75158747 Hi @andrewor14, this is no longer a WIP. It requires a rebase, but was hoping to get some feedback on the approach before working on that. --- If your project is set up f

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-75149359 Hi @jerryshao @sryza what is the status of this, is it still WIP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64317326 The main changes we implemented here are: * When a shuffle operation has a key ordering, sort records by key on the map side in addition to sorting by partition. * O

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/3438#discussion_r20845166 --- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala --- @@ -17,6 +17,7 @@ package org.apache.spark.rdd +import scala.collectio

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64306134 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64306132 [Test build #23809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23809/consoleFull) for PR 3438 at commit [`7d839cd`](https://gith

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64300144 [Test build #23809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23809/consoleFull) for PR 3438 at commit [`7d839cd`](https://githu

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64298924 [Test build #23807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23807/consoleFull) for PR 3438 at commit [`bfc2614`](https://gith

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64298925 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [WIP][SPARK-2926][Shuffle]Add MR style sort-me...

2014-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-64298835 [Test build #23807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23807/consoleFull) for PR 3438 at commit [`bfc2614`](https://githu