[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-07 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39706859 @AndreSchumacher [parquet.Log](https://github.com/Parquet/parquet-mr/blob/master/parquet-common/src/main/java/parquet/Log.java) has a static block ( add a default

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-07 Thread AndreSchumacher
Github user AndreSchumacher commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39773962 @witgo yes, it seems the parent handlers need to be set for the forwarding to work. My only remaining suggestion is to the log level. I still think setting it to

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-05 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39637576 `Seq(parquet.hadoop.ColumnChunkPageWriteStore, ...` parent logger is `Logger.getLogger(parquet)`. only need to set the `Logger.getLogger(parquet)` .

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39646636 So is the main problem here that parquet should not use a static block like this to do initialization? If so, @witgo do you mind documenting this in the code to explain

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39646782 Btw @julienledem in Spark we also add some default initialization, but we do it lazily instead of statically because this allows re-routing packages to statically

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39592160 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/325#discussion_r11306151 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -81,11 +81,14 @@ private[sql] case class ParquetRelation(val path:

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39593934 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39594128 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39594136 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39595364 There is a problem I do not know what the reason is cause import org.apache.spark.SparkContext import org.apache.spark.sql.SQLContext case class

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39597999 @AndreSchumacher, any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread AndreSchumacher
Github user AndreSchumacher commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39598624 Ouch. OK, I'll have a look at this. The default j.u.l. logger writes to stdout. Maybe the log forwarding doesn't work as intended. --- If your project is set up

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39600312 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39619758 [class parquet.Log](https://github.com/Parquet/parquet-mr/blob/master/parquet-common/src/main/java/parquet/Log.java) has a static block ( add a default handler in case

[GitHub] spark pull request: [WIP] Fix SPARK-1413: Parquet messes up stdout...

2014-04-04 Thread AndreSchumacher
Github user AndreSchumacher commented on the pull request: https://github.com/apache/spark/pull/325#issuecomment-39628746 @witgo that alone would not explain a deadlock of the forwarding is initialized multiple times? Unless maybe the log forwarding is called before parquet.Log is