[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-03 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42111962 LGTM too. Thanks for the clarifications, guys. Merging into master, branch-1.0, and branch-0.9. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-03 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42111008 This does look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42097557 @sryza so this looks good to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42096412 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42096413 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14631/ --- If your project

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42095785 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42095787 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42095752 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094847 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094848 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14630/ --- If your project is set up for it, you can r

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094276 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094271 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094124 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14629/ --- If your project is set up for it, you can r

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094123 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094097 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42094099 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12253872 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -24,25 +24,30 @@ import org.apache.hadoop.mapred.JobConf import org.apach

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42092767 To add to what Tom said, there's a distinction between "renewing" tokens and "repopulating" them. Renewing means extending the lifespan of existing tokens. Repopulating is

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42092592 There is no reason to recreate the user and repopulate the credentials/token unless the credentials/tokens are being updated in the ExecutorBackend process. On yarn thi

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42091219 I have tested this on standalone mode and confirmed that the file handles do not leak. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12252364 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -94,25 +95,32 @@ private[spark] class CoarseGrainedExecutor

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12252315 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -24,25 +24,30 @@ import org.apache.hadoop.mapred.JobConf import org.ap

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12252251 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -94,25 +95,32 @@ private[spark] class CoarseGrainedExecut

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12251478 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -94,25 +95,32 @@ private[spark] class CoarseGrainedExecutor

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/621#discussion_r12251357 --- Diff: core/src/main/scala/org/apache/spark/executor/MesosExecutorBackend.scala --- @@ -95,9 +95,13 @@ private[spark] class MesosExecutorBackend */

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42086088 This seems pretty reasonable to me, but it assumes that there is no value in recreating the user and re-transferring the current user's credentials. Is this the case? -

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42078000 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42078001 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14625/ --- If your project is set up for it, you can r

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42077873 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/621#issuecomment-42077867 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [WIP] SPARK-1676: Cache Hadoop UGIs by default...

2014-05-02 Thread tgravescs
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/621 [WIP] SPARK-1676: Cache Hadoop UGIs by default to prevent FileSystem leak Move the doAs in Executor higher up so that we only have 1 ugi and aren't leaking filesystems. Fix spark on yarn to wo