GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/714
ãSPARK-1779ãadd warning when memoryFraction is not between 0 and 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark memoryFraction
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12501550
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -76,6 +76,16 @@ class ExternalAppendOnlyMap[K, V, C](
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/714#issuecomment-42682542
We should probably throw an exception, actually. It's a pathological state
if the max memory is negative, or greater than what the JVM offers.
---
If your project is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/714#issuecomment-42682658
Could you also do that in `ExternalAppendOnlyMap`? There are two similar
configs there.
---
If your project is set up for it, you can reply to this email and have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12484999
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1045,6 +1045,9 @@ private[spark] object BlockManager extends Logging {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12484987
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -76,6 +76,16 @@ class ExternalAppendOnlyMap[K, V, C](
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/714#issuecomment-42729062
Thanks, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/714#issuecomment-42729492
ãSPARK-1779ã = [SPARK-1779]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12484965
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1045,6 +1045,9 @@ private[spark] object BlockManager extends Logging {
