Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user kozanitis commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-65169392
Yeah I see your point... I will revise the design as soon as I find some
time to do some more clever parsing of the existing predicates
---
If your project is set up f
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-65164578
Thanks for working on this, my biggest concern is adding new syntax to SQL
since it is something we will have to support forever. Would it instead be
possible to expres
Github user kozanitis commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60821550
Jenkins can you please test again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kozanitis commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60821525
Thanks @sarutak for the recommendations. After fixing the issues that you
found sbt/sbt -Phive scalastyle passed.
---
If your project is set up for it, you can reply t
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60562141
Hi @kozanitis , did you try to run "sbt/sbt -Phive scalastyle" ?
That command helps you, telling which code is invalid style.
Maybe, the length of some lines is ove
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392368
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLRangeJoinSuite.scala
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to Big Data Genomics
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392347
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLRangeJoinSuite.scala
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to Big Data Genomics
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392360
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLRangeJoinSuite.scala
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to Big Data Genomics
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392340
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -102,6 +102,13 @@ private[sql] abstract class SparkStrategies ex
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoins.scala ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392285
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoins.scala ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392296
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoins.scala ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoinImpl.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foun
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -188,8 +191,18 @@ class SqlParser extends AbstractSparkSQLParser {
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392161
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoinImpl.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foun
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392165
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoinImpl.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foun
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392150
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoins.scala ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/RangeJoins.scala ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2939#discussion_r19392124
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -556,6 +556,8 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterA
Github user kozanitis commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60550301
Any idea how to deal with those formatting errors? They come from files
that I didn't modify and I made sure I rebased just before pushing the commit
---
If your proje
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60535473
[Test build #469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/469/consoleFull)
for PR 2939 at commit
[`092c7c8`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60535431
[Test build #469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/469/consoleFull)
for PR 2939 at commit
[`092c7c8`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60475344
[Test build #434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/434/consoleFull)
for PR 2939 at commit
[`092c7c8`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60475266
[Test build #434 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/434/consoleFull)
for PR 2939 at commit
[`092c7c8`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2939#issuecomment-60469727
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user kozanitis opened a pull request:
https://github.com/apache/spark/pull/2939
Add range join support to spark-sql
This PR enables spark-sql to join two tables based on the interval
overlapping between their columns. This is a very useful feature to add as you
can see here:
27 matches
Mail list logo
