[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198804200 Yeah, we have another PR: https://github.com/apache/spark/pull/10566. That PR is waiting for the related PR merged. --- If your project is set up for it, you can r

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-197769134 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198777563 yes, the `OuterJoinElimination` rule in catalyst generalizes that and converts outer joins to either inner, left-outer or right-outer based on the filter conditio

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread antonoal
Github user antonoal closed the pull request at: https://github.com/apache/spark/pull/11777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198701153 @antonoal you'd have to close this PR. See https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is set up for it, you can reply t

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread antonoal
Github user antonoal commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198692338 It does cover all my tests and looks a lot neater, so feel free to decline this PR. Also do you know of the top of your head if there is a jira for converting an o

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-19 Thread antonoal
Github user antonoal commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198228257 Yes and no. This change handles a bit more cases, not just column == constant, and it works on an earlier phase - logical plan optimisation rather than physical. It is

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-18 Thread antonoal
GitHub user antonoal opened a pull request: https://github.com/apache/spark/pull/11777 Added transitive closure transformation to Catalyst ## What changes were proposed in this pull request? A relatively simple transformation is missing from Catalyst's arsenal - generation of tr

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198222192 This is similar to https://github.com/apache/spark/pull/11618 isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: Added transitive closure transformation to Cat...

2016-03-18 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11777#issuecomment-198240004 @antonoal Thanks a lot for looking into this! As @rxin pointed out, we currently infer these transitive predicates by looking at the data constraints for each op