GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12831
Fix lint errors on hive module.
## What changes were proposed in this pull request?
This issue fixes or hides 181 Java linter errors introduced by SPARK-14987
which copied hive service code from Hive. We had better clean up these errors
before releasing Spark 2.0.
- Fix UnusedImports (15 lines), RedundantModifier (14 lines), SeparatorWrap
(9 lines), MethodParamPad (6 lines), FileTabCharacter (5 lines), ArrayTypeStyle
(3 lines), ModifierOrder (3 lines), RedundantImport (1 line),
CommentsIndentation (1 line), UpperEll (1 line), FallThrough (1 line),
OneStatementPerLine (1 line), NewlineAtEndOfFile (1 line) errors.
- Ignore `LineLength` errors under `hive/service/*` (118 lines).
- Ignore `MethodName` error in `PasswdAuthenticationProvider.java` (1 line).
- Ignore `NoFinalizer` error in `ThreadWithGarbageCleanup.java` (1 line).
## How was this patch tested?
After passing Jenkins building, run `dev/lint-java` manually.
```bash
$ dev/lint-java
Checkstyle checks passed.
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-15053
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12831
----
commit 678cb593acf822770853093f10a10a1b172af4de
Author: Dongjoon Hyun <dongj...@apache.org>
Date: 2016-05-02T03:11:44Z
Fix lint errors on hive module.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
