[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90832887 [Test build #29848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29848/consoleFull) for PR 5407 at commit [`824adb3`](https://githu

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90831006 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90830987 [Test build #29836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29836/consoleFull) for PR 5407 at commit [`c877da7`](https://gith

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90822668 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90822661 [Test build #29834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29834/consoleFull) for PR 5407 at commit [`44dca71`](https://gith

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90821110 [Test build #29833 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29833/consoleFull) for PR 5407 at commit [`5a98a86`](https://gith

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90821116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90816329 [Test build #29836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29836/consoleFull) for PR 5407 at commit [`c877da7`](https://githu

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90808630 [Test build #29834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29834/consoleFull) for PR 5407 at commit [`44dca71`](https://githu

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90808482 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90808478 [Test build #29831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29831/consoleFull) for PR 5407 at commit [`6ce7d45`](https://gith

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/5407#discussion_r27944362 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -247,6 +250,7 @@ object CheckpointReader extends Logging { v

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90807277 [Test build #29833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29833/consoleFull) for PR 5407 at commit [`5a98a86`](https://githu

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/5407#discussion_r27944111 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -247,6 +250,7 @@ object CheckpointReader extends Logging { va

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/5407#discussion_r27944086 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -187,16 +189,17 @@ class CheckpointWriter( val bos = new Byte

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/5407#discussion_r27943884 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -139,9 +139,11 @@ class CheckpointWriter( // Write chec

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/5407#discussion_r27943877 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -139,9 +139,11 @@ class CheckpointWriter( // Write chec

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5407#issuecomment-90800714 [Test build #29831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29831/consoleFull) for PR 5407 at commit [`6ce7d45`](https://githu

[GitHub] spark pull request: Fix potential resource leaks in CheckPoint Che...

2015-04-07 Thread zhichao-li
GitHub user zhichao-li opened a pull request: https://github.com/apache/spark/pull/5407 Fix potential resource leaks in CheckPoint CheckpointWriter and CheckpointReader The close action should be placed within finally block to avoid the potential resource leaks You can merge this