[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-07 Thread dgshep
Github user dgshep commented on the pull request: https://github.com/apache/spark/pull/338#issuecomment-39748924 Done: https://issues.apache.org/jira/browse/SPARK-1432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/338#issuecomment-39687412 Okay this looks good to me. Do you mind creating a new JIRA for this and setting the title to something like: "stageIdToExecutorSummaries can lead to memory leak". And co

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread dgshep
Github user dgshep commented on a diff in the pull request: https://github.com/apache/spark/pull/338#discussion_r11328619 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -92,8 +91,10 @@ private[ui] class JobProgressListener(conf: SparkConf)

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/338#discussion_r11328357 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -92,8 +91,10 @@ private[ui] class JobProgressListener(conf: SparkConf)

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/338#discussion_r11328347 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -92,8 +91,10 @@ private[ui] class JobProgressListener(conf: SparkConf)

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/338#issuecomment-39682510 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: In the contex of SPARK-1337: Make sure that al...

2014-04-06 Thread dgshep
GitHub user dgshep opened a pull request: https://github.com/apache/spark/pull/338 In the contex of SPARK-1337: Make sure that all metadata fields are properly cleaned While working on spark-1337 with @pwendell, we noticed that not all of the metadata maps in JobProgessListener wer