Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39401757
@hirakendu Thanks a lot for the detailed comments and feedback. Yes, we
have a responsibility to keep improving the trees going forward so getting
additional feedback is
Github user hirakendu commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39396722
Thanks for noticing the typo, it's 500 million examples. Corrected it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user etrain commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39392123
Hi Hirakendu - thanks for all the detailed suggestions and information. I
will reply to that separately.
One question - you say there are 500,000 examples and this e
Github user hirakendu commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39390821
Since it's a long review, I have put things together in one place
[spark_mllib_tree_pr79_review.md](https://github.com/hirakendu/temp/blob/master/spark_mllib_tree_pr79_rev
Github user hirakendu commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39390268
In terms of running time performance, here are some scalability results for
a large scale dataset. Results look satisfactory :).
The code was tested on a dataset
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229944
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1150 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229920
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1150 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229869
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Algo.scala ---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Found
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229453
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Algo.scala ---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Found
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229365
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Founda
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229274
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Bin.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229300
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/InformationGainStats.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Softw
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229221
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229187
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229120
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/Split.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11229035
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/Filter.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11228983
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1150 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11228901
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Founda
Github user hirakendu commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39385736
Thanks Manish, Evan, Ameet, Ram, and thanks Xiangrui, Matei. It's great to
have this PR merged, but I think there is room for a lot of improvement, and I
hope this thread
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39288342
Excellent, thanks a lot Manish, Ram and others! I've merged this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39287513
@mateiz This looks good to me and I will mark some APIs
developer/experimental after it gets merged. Please help merge it.
Thanks @manishamde , @hirakendu , @etrain
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39169881
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13623/
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39169879
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39167685
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39167697
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39159295
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39159296
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13614/
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39155725
Merged build started. Build is starting -or- tests failed to complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39155715
Merged build triggered. Build is starting -or- tests failed to complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39155337
@manishamde Please merge the changes at
https://github.com/manishamde/spark/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11142394
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11142399
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Software Foun
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39155083
@mengxr I am not sure the merge of your PR on my repo went through. I might
have closed the PR accidentally and I can't find a way to undo it. Could you
please re-send y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39154884
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39154885
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13609/
---
If your project i
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11141936
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11141895
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Fou
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39153779
@manishamde I sent some minor code style updates to your repo. Please take
a look and merge it into this PR. Thanks!
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39150614
Merged build triggered. Build is starting -or- tests failed to complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39150623
Merged build started. Build is starting -or- tests failed to complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-39150548
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11103459
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11090794
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11089359
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11077636
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11074467
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11055502
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38887410
Merged build finished. Some tests failed or tests have not started running
yet.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38887411
Some tests failed or tests have not started running yet.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885625
Merged build triggered. One or more automated tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885632
Merged build started. One or more automated tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885583
Merged build finished. One or more automated tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885584
One or more automated tests failed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/Spark-prb/2/
---
If your project is set up f
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885516
Jenkins, this is okay to test. Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885518
Merged build triggered. One or more automated tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38885522
Merged build started. One or more automated tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11054196
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38881921
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11047729
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11001627
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r11000162
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10998536
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10965763
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10959264
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10957131
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user etrain commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10934747
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user hirakendu commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10926671
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Founda
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38529295
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38529297
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13419/
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38526805
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38526804
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10916114
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871626
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871549
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Variance.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871524
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Gini.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871491
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Gini.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871385
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38407632
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13378/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38407631
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38407348
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38407347
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10871098
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38377451
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38377452
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13363/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38376590
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38376589
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38376567
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38376569
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13361/
---
If your pr
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10866028
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38375820
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38375821
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13358/
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38375816
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38375815
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10865951
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10865926
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10865814
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10865809
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10865810
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1183 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-38375199
@mengxr Thanks a lot! LGTM. Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1 - 100 of 123 matches
Mail list logo
