[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-04-29 Thread schmit
Github user schmit closed the pull request at: https://github.com/apache/spark/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-03-21 Thread schmit
Github user schmit commented on the pull request: https://github.com/apache/spark/pull/160#issuecomment-38316626 Sorry, I am blind. Anyway, do you agree that 0.5 makes most sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-03-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/160#issuecomment-38319702 It's all functionally the same, sure. I'm launching a crusade against using doubles for labels (https://spark-project.atlassian.net/browse/MLLIB-29) so this would change

[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/160#issuecomment-37783040 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-03-16 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/160#issuecomment-37783918 If I may wade in with a comment. I am not clear a `BinaryClassificationModel` is needed. What it adds, the score method, seems to just return 0/1 depending on the

[GitHub] spark pull request: ROC area under the curve for binary classifica...

2014-03-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/160#discussion_r10645689 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/BinaryClassificationModel.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the