[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76823596 Thanks! Merged to master and 1.3 with a small change for java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4847 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4847#discussion_r25584861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -337,11 +337,11 @@ class DataFrame protected[sql]( * {{{ * // Scal

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76675615 LGTM since it's definitely the last arg that specifies the join type, as you can see there, but will give @rxin a day to look --- If your project is set up for it, you ca

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76665628 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-01 Thread peerside
GitHub user peerside opened a pull request: https://github.com/apache/spark/pull/4847 Refactored Dataframe join comment to use correct parameter ordering The API signatire for join requires the JoinType to be the third parameter. The code examples provided for join show JoinType bei