[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-06-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-45268270 Thanks I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-45162685 LGTM - @vanzin mind bringing this up to date? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-05-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/794 Remove compile-scoped junit dependency. This avoids having junit classes showing up in the assembly jar. I verified that only test classes in the jtransforms package use junit. You can merge

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43253650 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-05-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43280215 @vanzin Did you check the sbt side? Try `sbt/sbt assembly` and see whether we have junit classes inside? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-05-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43351634 Yeah, that pretty much has the same code. If it goes in I can close this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Remove compile-scoped junit dependency.

2014-05-16 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43288330 Related work #713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this