[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48376050 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48376054 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16410/ --- If your project

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48372372 Were all of those imports being removed not required after all to avoid warnings? as long as that's the case (i.e. no build warnings) yes this is great IMHO. --- If your

[GitHub] spark pull request: Resolve sbt warnings during build

Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48370238 LGTM if tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48369779 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-48369764 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Resolve sbt warnings during build

GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1330 Resolve sbt warnings during build At the same time, import the `scala.language.postfixOps` and ` org.scalatest.time.SpanSugar._` cause `scala.language.postfixOps` doesn't work You can merge this pull

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-48287243 @witgo Go ahead. Right now I actually don't see any warnings appear when the compiler flag is removed, so it looks like all other warnings are suppressed locally already.

[GitHub] spark pull request: Resolve sbt warnings during build

Github user witgo closed the pull request at: https://github.com/apache/spark/pull/1069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: Resolve sbt warnings during build

Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-48285811 @srowen If so, I close the PR and I will submit a new PR meets you said. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: Resolve sbt warnings during build

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-48281718 Thanks for summarizing that. I agree that we should not have a global flag that just disables certain warnings, since that could hide potential problems in the future. --

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-48281479 @rxin It looks like Scala is requiring developers to be more explicit about intention to use these features; these warnings become errors in Scala 2.11 actually. So my opi

[GitHub] spark pull request: Resolve sbt warnings during build

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-48280716 Can one of you give me a tl;dr on the verdict about this one? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-48280658 Thanks. Merging this in master and branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47591417 This would be nice to get in before 1.0.1 just to clean up those ugly compiler warnings. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47314416 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47314418 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16197/ --- If your project

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47309609 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47309600 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47056690 This PR is the subsequent optimization of #713 ,should only merge to the master. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-47056376 @witgo mind merging this to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-46660823 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15954/ --- If your project

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-46660820 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-46654856 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Resolve sbt warnings during build � �

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1153#issuecomment-46654843 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Resolve sbt warnings during build � �

GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1153 Resolve sbt warnings during build Ⅱ You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark expectResult Alternatively you can review an

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46006402 I'm more concerned with consistency than anything. We shouldn't do it both ways, and I don't think that compiler arg should have been added. A compiler flag is not a bad s

[GitHub] spark pull request: Resolve sbt warnings during build

Github user huitseeker commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46006160 Fair enough. I just meant to provide context. Note that [this commit](https://github.com/apache/spark/commit/41c4a33105c74417192925db355019ba1badeab2) has al

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46004821 Yes, I understand that, but these warnings are already suppressed with imports, and the advertised change here is to resolve warnings. It just exchanges mechanisms for sup

[GitHub] spark pull request: Resolve sbt warnings during build

Github user huitseeker commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46004365 It resolves the warning the following warning, which occurs in different (but easy-to-reach) contexts depending on whether you are running with the `-language` option

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46002724 Yes, but then what warnings is this resolving? I understand one compiler flag is shorter than imports. I also understand that these language features are considere

[GitHub] spark pull request: Resolve sbt warnings during build

Github user huitseeker commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-46002024 @witgo @pwendell @srowen Correct : adding `-language:postfixOps` to your `scalac` line (`scalacOptions` for sbt) will remove the warning. --- If your project is set

[GitHub] spark pull request: Resolve sbt warnings during build

Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45969396 @srowen If we use "-language:postfixOps" This `scala.language.postfixOps` is not necessary. as proposed in the [SIP-18 document](https://docs.google.com/document/d/1nl

[GitHub] spark pull request: Resolve sbt warnings during build

Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45941553 @srowen @witgo - as far as I can tell, this _adds_ rather than removes build warnings. I also noticed that your patch #1032 actually caused new warnings because you remo

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45917828 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15711/ --- If your project

[GitHub] spark pull request: Resolve sbt warnings during build

Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45918415 The changes you are removing were put in place to resolve warnings from Scala 2.10. IIRC the code does not even compile without these in Scala 2.11. What is this resolving

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45917827 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45912227 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Resolve sbt warnings during build

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45912242 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Resolve sbt warnings during build

GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1069 Resolve sbt warnings during build You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark sbt_warnings Alternatively you can review and apply