[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141561521 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141561523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141561335 [Test build #42673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42673/console) for PR 8822 at commit [`007c6d6`](https://github.

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/8822#discussion_r39883150 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -97,7 +97,7 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAlloc

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/spark/pull/8822 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141520065 OK let's close this PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141519890 This is a duplicate. Let's move convo to https://github.com/apache/spark/pull/8749 Yes, definitely not OK to expose the mutable object. --- If your project is set up f

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141519586 @rxin yes that was my comment, but do you think we should add a getter for it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141519443 [Test build #42673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42673/consoleFull) for PR 8822 at commit [`007c6d6`](https://gith

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8822#discussion_r39882168 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -97,7 +97,7 @@ class SparkContext(config: SparkConf) extends Logging with Executor

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141519199 @srowen @JoshRosen do you guys think this is a good idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: SPARK-10701 Expose SparkContext#stopped flag w...

2015-09-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8822#issuecomment-141519233 -1 I don't think we should just expose an atomic variable directly. --- If your project is set up for it, you can reply to this email and have your reply appear o