Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r42897746
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1337,55 +1337,8 @@ object Client extends Logging {
conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r42898469
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1337,55 +1337,8 @@ object Client extends Logging {
conf:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150662642
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r42897540
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -322,8 +322,10 @@ private[spark] class Client(
// multiple
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150655438
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150655380
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r42881320
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -322,8 +322,10 @@ private[spark] class Client(
// multiple times,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150684229
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150684298
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150695706
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150695732
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150697465
**[Test build #44260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44260/consoleFull)**
for PR 9232 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150726454
@steveloughran could you use PR titles following the convention described
in the following document?
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150688417
Updated patch
1. Moves all arg validation up before any hive class reflection
1. gets all hive class methods before attempting to call any
1. calls
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150688788
**[Test build #44257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44257/consoleFull)**
for PR 9232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150693689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150693568
**[Test build #44257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44257/consoleFull)**
for PR 9232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701020
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150700891
I've tightened this up and am happy with the code now, except I'm not sure
that NoSuchMethodExceptions should be downgraded. It will hide the situation of
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701035
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150704237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150704233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150704157
**[Test build #44264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44264/consoleFull)**
for PR 9232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150693686
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701247
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701155
**[Test build #44260 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44260/consoleFull)**
for PR 9232 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150701221
**[Test build #44264 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44264/consoleFull)**
for PR 9232 at commit
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150658089
Patch with revert posted
For reviewers, here some things to consider
1. Which exceptions should trigger log & skip for token, vs which are
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150657934
**[Test build #44244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44244/consoleFull)**
for PR 9232 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150662508
**[Test build #44244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44244/consoleFull)**
for PR 9232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150662640
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
32 matches
Mail list logo