[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-24 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38530729 All set, feel free to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38530691 @aarondav this all set or do you have more changes planned? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-24 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38529423 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38390797 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13368/ --- If your project

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38390796 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38390056 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/184#discussion_r10868103 --- Diff: bin/load-spark-env.sh --- @@ -0,0 +1,35 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38388662 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38388664 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/184#discussion_r10867988 --- Diff: bin/load-spark-env.sh --- @@ -0,0 +1,35 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-23 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38375866 All comments have been addressed, this is ready for further review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-20 Thread ash211
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38248187 +1 I reported this on the mailing list a while back --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38139933 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13294/ --- If your project

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38139932 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38137727 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38137726 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/184#discussion_r10783017 --- Diff: bin/load-spark-env --- @@ -0,0 +1,35 @@ +#!/usr/bin/env bash --- End diff -- To be consistent with other scripts, can we call this `lo

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38128989 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13286/ --- If your p

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38128988 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38128535 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/184#issuecomment-38128534 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...

2014-03-19 Thread aarondav
GitHub user aarondav opened a pull request: https://github.com/apache/spark/pull/184 SPARK-1286: Make usage of spark-env.sh idempotent Various spark scripts load spark-env.sh. This can cause growth of any variables that may be appended to (SPARK_CLASSPATH, SPARK_REPL_OPTS) and it m