[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173304812 **[Test build #2420 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2420/consoleFull)** for PR 10825 at commit

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173332479 **[Test build #2420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2420/consoleFull)** for PR 10825 at commit

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-17387 Merging this in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-17512 BTW @rajeshbalamohan in the future can you follow the format for your pull request title? [SPARK-][SQL] Thanks. --- If your project is set up

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173070111 Thanks for the explanation. It would be great to add comment in the code that you are changing to explain why the duummy callsite is useful. --- If your project is set

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173038558 I think that we may have seen similar `getCallSite` issues in the past, if my memory's right (try searching JIRA). --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173037438 getCallSite gets the thread stack trace (+ additional processing). This is executed numerous number of times when running a query on TPC-DS (with 1800+

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173109060 **[Test build #2419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2419/consoleFull)** for PR 10825 at commit

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173106715 Thanks for review. I have added a comment in the code for the same. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173108734 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-173108923 **[Test build #2419 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2419/consoleFull)** for PR 10825 at commit

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-172734435 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-18 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/10825 SPARK-12898. Consider having dummyCallSite for HiveTableScan Currently, HiveTableScan runs with getCallSite which is really expensive and shows up when scanning through large table with

[GitHub] spark pull request: SPARK-12898. Consider having dummyCallSite for...

2016-01-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10825#issuecomment-172755241 Can you explain more about "HiveTableScan runs with getCallSite which is really expensive and shows up when scanning through large table with partitions"? What's