[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192233422 Merged to master, since this fixes https://github.com/apache/spark/pull/10848 also merged only to master. If there's some other issue with 1.6 we should talk about it

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192229240 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192229353 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192229356 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192228903 **[Test build #52459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52459/consoleFull)** for PR 11477 at commit

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192196395 **[Test build #52459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52459/consoleFull)** for PR 11477 at commit

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192194877 @rajeshbalamohan you're saying this fixes a problem in 1.6 only? Looks OK to me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192194908 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-03 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-192146953 Thanks @srowen . Incorporated the changes. This was tested with HiveCompatibilitySuite, HiveQuerySuite. These tests ran fine in master branch without

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11477#discussion_r54853932 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala --- @@ -320,9 +320,11 @@ private[hive] trait HiveInspectors {

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-191501586 @rajeshbalamohan in the future can you use the pull request template? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11477#issuecomment-191497491 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12925. Improve HiveInspectors.unwrap for...

2016-03-02 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/11477 SPARK-12925. Improve HiveInspectors.unwrap for StringObjectInspector.… Earlier fix did not copy the bytes and it is possible for higher level to reuse Text object. This was causing