[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-3963 No worries, thanks a lot to both you and Haoyuan for putting this together! This will be a great feature to have. --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread RongGu
Github user RongGu commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39629454 It seems that I just missed our last part. I am so happy this PR is merged. Thank @pwendell, @mateiz and @aarondav for your valuable comments all the way. Also, I apprecia

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39627882 Merging cleanly now. I merged this - thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39627050 @mateiz See if it works now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39626834 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13788/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39626833 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39625592 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39625593 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39625378 HY, it still doesn't merge. I see `CONFLICT (content): Merge conflict in core/src/main/scala/org/apache/spark/util/Utils.scala`. Maybe you didn't update to the very latest

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39624668 @mateiz Merged the master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39624029 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13782/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39624027 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620883 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620876 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620636 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620661 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620639 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620663 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13781/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620496 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620497 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13780/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620410 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39620406 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39618664 Hey HY, one final thing, this PR no longer merges cleanly because of some other recent changes to pom.xml and SparkBuild.scala. Mind merging master into it, or rebasing it?

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39618245 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39613745 @mateiz @aarondav All issues should have been addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39612704 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39612706 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13774/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread haoyuan
Github user haoyuan commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11314127 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39607877 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39607858 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11309737 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala --- @@ -30,45 +31,54 @@ import java.io.{Externalizable, IOException, ObjectInput, Obj

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11308914 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11308833 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala --- @@ -30,45 +31,54 @@ import java.io.{Externalizable, IOException, ObjectInput, O

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39593128 Jenkins, test this please Thanks HY! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39589896 @mateiz Your latest comment should have been addressed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39543609 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39543610 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13755/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39540229 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39540222 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-03 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11264777 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -669,7 +717,7 @@ private[spark] class BlockManager( // Either we

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39418489 Hi @mateiz and @aarondav , Thanks for the comments. All of them should have been addressed. --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411820 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411821 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13716/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411307 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411305 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411309 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13713/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39411310 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13712/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39410737 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39410738 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13711/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39409520 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39409530 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39408269 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39408264 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39407856 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39407860 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39406732 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39406738 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39388751 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13693/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39388749 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11227619 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -620,6 +651,24 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39383192 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39383173 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11227538 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread haoyuan
Github user haoyuan commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11227073 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorExitCode.scala --- @@ -41,6 +41,12 @@ object ExecutorExitCode { /** DiskStore failed to

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread haoyuan
Github user haoyuan commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11227057 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread haoyuan
Github user haoyuan commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11226993 --- Diff: core/pom.xml --- @@ -206,6 +206,53 @@ test + org.tachyonproject --- End diff -- No. They won't. S

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11225116 --- Diff: core/pom.xml --- @@ -206,6 +206,53 @@ test + org.tachyonproject --- End diff -- Will Powermock and

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11225067 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -59,6 +57,17 @@ private[spark] class BlockManager( private[storage

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11224981 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39300325 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13674/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39300324 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39298749 Left some minor comments and a couple higher level questions -- it's likely these questions have been discussed before, I just want to make sure because they could indica

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39298584 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13673/ --- If your project

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39298583 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195537 --- Diff: project/SparkBuild.scala --- @@ -277,11 +277,18 @@ object SparkBuild extends Build { val slf4jVersion = "1.7.5" val excludeNetty

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195556 --- Diff: project/SparkBuild.scala --- @@ -277,11 +277,18 @@ object SparkBuild extends Build { val slf4jVersion = "1.7.5" val excludeNetty

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195474 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195342 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195315 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195271 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11195032 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194950 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194943 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194937 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39296167 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39296168 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13672/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194857 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -248,8 +257,10 @@ private[spark] class BlockManager( if (info.tellMa

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39295932 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39295925 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194776 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -59,6 +57,17 @@ private[spark] class BlockManager( private[stora

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread haoyuan
Github user haoyuan commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194656 --- Diff: core/pom.xml --- @@ -206,6 +206,53 @@ test + org.tachyonproject --- End diff -- Seems this one ex

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194637 --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonBlockManager.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194622 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -21,12 +21,11 @@ import java.io._ import java.net.URI import java.util.{Prop

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/158#discussion_r11194613 --- Diff: core/pom.xml --- @@ -206,6 +206,53 @@ test + org.tachyonproject --- End diff -- The exclusions h

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39294689 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39293478 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39293201 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39293197 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1305: Support persisting RDD's directly ...

2014-04-01 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/158#issuecomment-39281328 Hey @RongGu and @haoyuan , thanks again for the latest updates. I pointed out a few small naming issues to make sure the API is complete. Apart from this, there are a few o

  1   2   3   >