[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/1173#discussion_r14062363 --- Diff: core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala --- @@ -83,7 +83,7 @@ private[spark] class RollingFileAppender(

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/1173#discussion_r14062333 --- Diff: core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala --- @@ -83,7 +83,7 @@ private[spark] class RollingFileAppender(

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46789151 Thanks. I've merged this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46779166 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16011/ --- If your project

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46779165 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46778249 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46778248 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46774098 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16006/ --- If your project

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46774097 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46773550 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46773551 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46773549 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/1173#discussion_r14052689 --- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala --- @@ -18,15 +18,18 @@ package org.apache.spark.util import java.io.

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46768765 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46768766 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16001/ --- If your project

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/1173 SPARK-1316. Remove use of Commons IO Commons IO is actually barely used, and is not a declared dependency. This just replaces with equivalents from the JDK and Guava. You can merge this pull request

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46768135 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1173#issuecomment-46768134 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38594054 I merged this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38592701 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13434/ --- If your project

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38592699 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38592358 Jenkins, are you happy yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38590037 Looks good to me if Jenkins is happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38584879 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/226#issuecomment-38584878 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1316. Remove use of Commons IO

2014-03-25 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/226 SPARK-1316. Remove use of Commons IO (This follows from a side point on SPARK-1133, in discussion of the PR: https://github.com/apache/spark/pull/164 ) Commons IO is barely used in the projec