[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39529938 LGTM also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39507068 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39483328 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39483329 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13725/ --- If your project

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39476959 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39476946 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/310#discussion_r11261202 --- Diff: bin/spark-shell --- @@ -145,7 +145,7 @@ function resolve_spark_master(){ fi if [ -z "$MASTER" ]; then -MASTER="$D

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/310#discussion_r11246612 --- Diff: bin/spark-shell --- @@ -145,7 +145,7 @@ function resolve_spark_master(){ fi if [ -z "$MASTER" ]; then -MASTER="$DEF

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39409966 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39409967 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13715/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39409526 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/310#issuecomment-39409518 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/310#discussion_r11238082 --- Diff: bin/spark-shell --- @@ -145,7 +145,7 @@ function resolve_spark_master(){ fi if [ -z "$MASTER" ]; then -MASTER="$D

[GitHub] spark pull request: SPARK-1404: Always upgrade spark-env.sh vars t...

2014-04-02 Thread aarondav
GitHub user aarondav opened a pull request: https://github.com/apache/spark/pull/310 SPARK-1404: Always upgrade spark-env.sh vars to environment vars This was broken when spark-env.sh was made idempotent, as the idempotence check is an environment variable, but the spark-env.sh vari