[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41511884 Okay I went ahead and merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41511160 Yes, that is exactly what I was referring to - since the committer specifies the branches to commit to; use that to populate the JIRA field. If this is being done - the

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread pwendell
Github user pwendell closed the pull request at: https://github.com/apache/spark/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread pwendell
GitHub user pwendell reopened a pull request: https://github.com/apache/spark/pull/570 SPARK-1648 Support closing JIRA's as part of merge script. Adds an automated hook in the merge script that can close the JIRA, set the fix versions, and leave a comment on the JIRA indicating

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41504640 Actually it goes the other way - we ask the committer to say what branches it gets merged into, and then we set the fix version on the JIRA based on that. --- If your p

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41503564 I meant, depending on which branch it is committed to, update Fix Version in jira ? Usual expectation is for this field to be appropriately updated : though I am prett

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41502814 @mridulm not sure what you mean by "update the branches"? this sets the fix version on the JIRA according to which branches the PR was committed to. For your sec

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-27 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41501708 Not review of the PR, but this is a great addition ! Btw, does it also update the branch(es) that the PR was committed to ? What about leaving the JIRA unresolved (p

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41489608 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41489609 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14515/ --- If your project

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41489173 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/570#issuecomment-41489169 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1648 Support closing JIRA's as part of m...

2014-04-26 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/570 SPARK-1648 Support closing JIRA's as part of merge script. Ads an automated hook in the merge script that can close the JIRA, set the fix versions, and leave a comment on the JIRA indicating the